From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 525CDC10F13 for ; Tue, 9 Apr 2019 02:09:42 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9695213F2 for ; Tue, 9 Apr 2019 02:09:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9695213F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44dW2D0ylvzDqK6 for ; Tue, 9 Apr 2019 12:09:40 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux.intel.com (client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=ricardo.neri-calderon@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44dVyr3Kq1zDqK6 for ; Tue, 9 Apr 2019 12:06:43 +1000 (AEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 19:06:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,327,1549958400"; d="scan'208";a="221742121" Received: from ranerica-svr.sc.intel.com ([172.25.110.23]) by orsmga001.jf.intel.com with ESMTP; 08 Apr 2019 19:06:39 -0700 Date: Mon, 8 Apr 2019 19:05:30 -0700 From: Ricardo Neri To: Thomas Gleixner Subject: Re: [RFC PATCH v2 09/14] watchdog/hardlockup: Make arch_touch_nmi_watchdog() to hpet-based implementation Message-ID: <20190409020530.GA7197@ranerica-svr.sc.intel.com> References: <1551283518-18922-1-git-send-email-ricardo.neri-calderon@linux.intel.com> <1551283518-18922-10-git-send-email-ricardo.neri-calderon@linux.intel.com> <20190227161758.GE4072@linux.ibm.com> <20190301011713.GA8058@ranerica-svr.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Rafael J. Wysocki" , Peter Zijlstra , Alexei Starovoitov , Kai-Heng Feng , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, "Paul E. McKenney" , Ingo Molnar , Christoffer Dall , Davidlohr Bueso , Ashok Raj , x86@kernel.org, David Rientjes , Andi Kleen , Waiman Long , Borislav Petkov , Don Zickus , "Ravi V. Shankar" , Konrad Rzeszutek Wilk , Marc Zyngier , Frederic Weisbecker , Nicholas Piggin , Ricardo Neri , Byungchul Park , Mathieu Desnoyers , Josh Poimboeuf , Tony Luck , Babu Moger , Randy Dunlap , linux-kernel@vger.kernel.org, "Luis R. Rodriguez" , Masami Hiramatsu , Philippe Ombredanne , Colin Ian King , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Mar 26, 2019 at 10:20:41PM +0100, Thomas Gleixner wrote: > On Thu, 28 Feb 2019, Ricardo Neri wrote: > > > > > > > > -#if defined(CONFIG_HARDLOCKUP_DETECTOR_PERF) > > > > +#if defined(CONFIG_HARDLOCKUP_DETECTOR_PERF) || \ > > > > + defined(CONFIG_X86_HARDLOCKUP_DETECTOR_HPET) > > > > > > Why not instead make CONFIG_X86_HARDLOCKUP_DETECTOR_HPET select > > > CONFIG_HARDLOCKUP_DETECTOR_PERF? Keep the arch-specific details > > > in the arch-specific files and all that. > > > > Thanks for your feedback, Paul! The HPET implementation does not use > > perf. Thus, in my opinion is not correct for the HPET HLD to select > > the perf implementation. Patch 8 of this series splits the perf-specific > > code and the generic hardlockup detector code. Does this make sense? > > That's what intermediate config symbols are for. > > config HARDLOCKUP_DETECTOR_CORE > bool > > And make both PERF and HPET select it. I'll implement it in this manner. Thanks and BR, Ricardo