From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58FA6C282CE for ; Tue, 9 Apr 2019 11:36:41 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C97BB20883 for ; Tue, 9 Apr 2019 11:36:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="sOS3EzK0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C97BB20883 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44dlcQ3zZdzDqJj for ; Tue, 9 Apr 2019 21:36:38 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=peterz@infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="sOS3EzK0"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44dlZB48VqzDqLp for ; Tue, 9 Apr 2019 21:34:42 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9As9lymReqB8M1UxoTk2pigPZNCxLpfhb2NVImuLGIE=; b=sOS3EzK0ZSN+9uc66v3iaMF0S qnydfgGdrI7Jgn20mjQnaZdsLPiNJd7fKK49/5Uk7p9CNKahKsMfcUZ1MnWOTJ/dpgzadtsDWvCbj Ln4R1AHmtgWQU/2/Bs0uSsyqFwInv5xe8Adjh7KQaMjV4vwK2XJT4GpXVM5M1TPdfK+c+oUq9hbTy OGOVoEjTyakYFggHdmEaxMyvbDDLoLpuOnm8Oi2kGrKuA3lhZnC45EIkpOE468QG1KpvaWgLJquuZ bcdRM5nvN4EhMxrstktt4VwiaM26o9WXeK1QBYX9DfO7LiKLBXJjBLwPs+OM12ua8KKy3gep+qXTM R57jUR3+Q==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDp1C-0007ta-T2; Tue, 09 Apr 2019 11:34:23 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 400B429B1224C; Tue, 9 Apr 2019 13:34:21 +0200 (CEST) Date: Tue, 9 Apr 2019 13:34:21 +0200 From: Peter Zijlstra To: Ricardo Neri Subject: Re: [RFC PATCH v2 10/14] kernel/watchdog: Add a function to obtain the watchdog_allowed_mask Message-ID: <20190409113421.GU4038@hirez.programming.kicks-ass.net> References: <1551283518-18922-1-git-send-email-ricardo.neri-calderon@linux.intel.com> <1551283518-18922-11-git-send-email-ricardo.neri-calderon@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1551283518-18922-11-git-send-email-ricardo.neri-calderon@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Rafael J. Wysocki" , Alexei Starovoitov , Kai-Heng Feng , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Ingo Molnar , Christoffer Dall , Davidlohr Bueso , Ashok Raj , x86@kernel.org, David Rientjes , Andi Kleen , Waiman Long , Borislav Petkov , Don Zickus , "Ravi V. Shankar" , Konrad Rzeszutek Wilk , Marc Zyngier , Frederic Weisbecker , Nicholas Piggin , Ricardo Neri , Byungchul Park , Mathieu Desnoyers , Josh Poimboeuf , "Paul E. McKenney" , Thomas Gleixner , Tony Luck , Babu Moger , Randy Dunlap , linux-kernel@vger.kernel.org, "Luis R. Rodriguez" , Masami Hiramatsu , Philippe Ombredanne , Colin Ian King , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Feb 27, 2019 at 08:05:14AM -0800, Ricardo Neri wrote: > diff --git a/kernel/watchdog.c b/kernel/watchdog.c > index 8fbfda94a67b..367aa81294ef 100644 > --- a/kernel/watchdog.c > +++ b/kernel/watchdog.c > @@ -44,7 +44,7 @@ int __read_mostly soft_watchdog_user_enabled = 1; > int __read_mostly watchdog_thresh = 10; > int __read_mostly nmi_watchdog_available; > > -struct cpumask watchdog_allowed_mask __read_mostly; > +static struct cpumask watchdog_allowed_mask __read_mostly; > > struct cpumask watchdog_cpumask __read_mostly; > unsigned long *watchdog_cpumask_bits = cpumask_bits(&watchdog_cpumask); Hurmph, more struct cpumask, ideally this would get converted to cpumask_var_t, I don't think we need this before the allocators work, do we?