From: Bharata B Rao <bharata@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Bharata B Rao <bharata@linux.ibm.com>,
aneesh.kumar@linux.vnet.ibm.com, david@gibson.dropbear.id.au
Subject: [PATCH] powerpc/pseries: Provide verbose info about HPT resizing attempt
Date: Wed, 10 Apr 2019 13:25:55 +0530 [thread overview]
Message-ID: <20190410075555.9357-1-bharata@linux.ibm.com> (raw)
When HPT resizing is attempted in response to memory hotplug, we see
the following messages from the kernel:
lpar: Attempting to resize HPT to shift 23
Unable to resize hash page table to target order 23: -28
This gives a feeling as though we are trying to grow HPT but failed and
hence bad things might happen in future. Improve the message a bit
by explicitly printing the existing HPT shift value in addtion to
the newly targeted value so that it is clear that we haven't failed
to grow HPT. After this commit, the same message will appear like this:
lpar: Attempting to resize HPT from shift 25 to 23
Unable to resize hash page table to target order 23: -28
Signed-off-by: Bharata B Rao <bharata@linux.ibm.com>
---
arch/powerpc/platforms/pseries/lpar.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/lpar.c b/arch/powerpc/platforms/pseries/lpar.c
index f2a9f0adc2d3..ecc7fa1876a9 100644
--- a/arch/powerpc/platforms/pseries/lpar.c
+++ b/arch/powerpc/platforms/pseries/lpar.c
@@ -875,7 +875,8 @@ static int pseries_lpar_resize_hpt(unsigned long shift)
if (!firmware_has_feature(FW_FEATURE_HPT_RESIZE))
return -ENODEV;
- pr_info("Attempting to resize HPT to shift %lu\n", shift);
+ pr_info("Attempting to resize HPT from shift %llu to %lu\n", ppc64_pft_size,
+ shift);
t0 = ktime_get();
--
2.17.1
next reply other threads:[~2019-04-10 7:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 7:55 Bharata B Rao [this message]
2019-04-10 10:20 ` [PATCH] powerpc/pseries: Provide verbose info about HPT resizing attempt Michael Ellerman
2019-04-10 9:49 ` Bharata B Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410075555.9357-1-bharata@linux.ibm.com \
--to=bharata@linux.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).