* [PATCH V2] ASoC: fsl_esai: replace fall-through with break
@ 2019-04-10 2:42 S.j. Wang
2019-04-10 3:53 ` Nicolin Chen
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: S.j. Wang @ 2019-04-10 2:42 UTC (permalink / raw)
To: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com,
festevam@gmail.com, broonie@kernel.org,
alsa-devel@alsa-project.org, gustavo@embeddedor.com
Cc: linuxppc-dev@lists.ozlabs.org
case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of
each other, so replace fall-through with break.
Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver")
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
Changes in v2
- fix the fixes tag.
sound/soc/fsl/fsl_esai.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
index c7410bbfd2af..bad0dfed6b68 100644
--- a/sound/soc/fsl/fsl_esai.c
+++ b/sound/soc/fsl/fsl_esai.c
@@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id,
break;
case ESAI_HCKT_EXTAL:
ecr |= ESAI_ECR_ETI;
- /* fall through */
+ break;
case ESAI_HCKR_EXTAL:
ecr |= esai_priv->synchronous ? ESAI_ECR_ETI : ESAI_ECR_ERI;
break;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2] ASoC: fsl_esai: replace fall-through with break
2019-04-10 2:42 [PATCH V2] ASoC: fsl_esai: replace fall-through with break S.j. Wang
@ 2019-04-10 3:53 ` Nicolin Chen
2019-04-10 11:28 ` Mark Brown
2019-04-10 14:31 ` Gustavo A. R. Silva
2 siblings, 0 replies; 6+ messages in thread
From: Nicolin Chen @ 2019-04-10 3:53 UTC (permalink / raw)
To: S.j. Wang
Cc: alsa-devel@alsa-project.org, timur@kernel.org,
gustavo@embeddedor.com, linuxppc-dev@lists.ozlabs.org,
Xiubo.Lee@gmail.com, broonie@kernel.org, festevam@gmail.com
On Wed, Apr 10, 2019 at 02:42:45AM +0000, S.j. Wang wrote:
> case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of
> each other, so replace fall-through with break.
>
> Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver")
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Thanks
> ---
> Changes in v2
> - fix the fixes tag.
>
> sound/soc/fsl/fsl_esai.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
> index c7410bbfd2af..bad0dfed6b68 100644
> --- a/sound/soc/fsl/fsl_esai.c
> +++ b/sound/soc/fsl/fsl_esai.c
> @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id,
> break;
> case ESAI_HCKT_EXTAL:
> ecr |= ESAI_ECR_ETI;
> - /* fall through */
> + break;
> case ESAI_HCKR_EXTAL:
> ecr |= esai_priv->synchronous ? ESAI_ECR_ETI : ESAI_ECR_ERI;
> break;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] ASoC: fsl_esai: replace fall-through with break
2019-04-10 2:42 [PATCH V2] ASoC: fsl_esai: replace fall-through with break S.j. Wang
2019-04-10 3:53 ` Nicolin Chen
@ 2019-04-10 11:28 ` Mark Brown
2019-04-11 3:09 ` [EXT] " S.j. Wang
2019-04-10 14:31 ` Gustavo A. R. Silva
2 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2019-04-10 11:28 UTC (permalink / raw)
To: S.j. Wang
Cc: alsa-devel@alsa-project.org, timur@kernel.org,
gustavo@embeddedor.com, linuxppc-dev@lists.ozlabs.org,
Xiubo.Lee@gmail.com, nicoleotsuka@gmail.com, festevam@gmail.com
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
On Wed, Apr 10, 2019 at 02:42:45AM +0000, S.j. Wang wrote:
> case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of
> each other, so replace fall-through with break.
This doesn't apply against current code, please check and resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] ASoC: fsl_esai: replace fall-through with break
2019-04-10 2:42 [PATCH V2] ASoC: fsl_esai: replace fall-through with break S.j. Wang
2019-04-10 3:53 ` Nicolin Chen
2019-04-10 11:28 ` Mark Brown
@ 2019-04-10 14:31 ` Gustavo A. R. Silva
2019-04-11 2:48 ` [EXT] " S.j. Wang
2 siblings, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-10 14:31 UTC (permalink / raw)
To: S.j. Wang, timur@kernel.org, nicoleotsuka@gmail.com,
Xiubo.Lee@gmail.com, festevam@gmail.com, broonie@kernel.org,
alsa-devel@alsa-project.org
Cc: linuxppc-dev@lists.ozlabs.org
On 4/9/19 9:42 PM, S.j. Wang wrote:
> case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of
> each other, so replace fall-through with break.
>
I think you should change the subject line to:
fix missing break in switch statement
...because you are fixing a bug, and it's important to put emphasis on
that in the subject line.
Also, notice that this bug has been out there for more than 5 years now,
so you should also tag this for stable.
Thanks
--
Gustavo
> Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver")
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> Changes in v2
> - fix the fixes tag.
>
> sound/soc/fsl/fsl_esai.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
> index c7410bbfd2af..bad0dfed6b68 100644
> --- a/sound/soc/fsl/fsl_esai.c
> +++ b/sound/soc/fsl/fsl_esai.c
> @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id,
> break;
> case ESAI_HCKT_EXTAL:
> ecr |= ESAI_ECR_ETI;
> - /* fall through */
> + break;
> case ESAI_HCKR_EXTAL:
> ecr |= esai_priv->synchronous ? ESAI_ECR_ETI : ESAI_ECR_ERI;
> break;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [EXT] Re: [PATCH V2] ASoC: fsl_esai: replace fall-through with break
2019-04-10 14:31 ` Gustavo A. R. Silva
@ 2019-04-11 2:48 ` S.j. Wang
0 siblings, 0 replies; 6+ messages in thread
From: S.j. Wang @ 2019-04-11 2:48 UTC (permalink / raw)
To: Gustavo A. R. Silva, timur@kernel.org, nicoleotsuka@gmail.com,
Xiubo.Lee@gmail.com, festevam@gmail.com, broonie@kernel.org,
alsa-devel@alsa-project.org
Cc: linuxppc-dev@lists.ozlabs.org
Hi
>
>
> On 4/9/19 9:42 PM, S.j. Wang wrote:
> > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent
> of
> > each other, so replace fall-through with break.
> >
> I think you should change the subject line to:
>
> fix missing break in switch statement
>
> ...because you are fixing a bug, and it's important to put emphasis on that in
> the subject line.
>
> Also, notice that this bug has been out there for more than 5 years now, so
> you should also tag this for stable.
>
> Thanks
> --
> Gustavo
>
Ok, will send v3.
>
> > Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver")
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > ---
> > Changes in v2
> > - fix the fixes tag.
> >
> > sound/soc/fsl/fsl_esai.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index
> > c7410bbfd2af..bad0dfed6b68 100644
> > --- a/sound/soc/fsl/fsl_esai.c
> > +++ b/sound/soc/fsl/fsl_esai.c
> > @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai
> *dai, int clk_id,
> > break;
> > case ESAI_HCKT_EXTAL:
> > ecr |= ESAI_ECR_ETI;
> > - /* fall through */
> > + break;
> > case ESAI_HCKR_EXTAL:
> > ecr |= esai_priv->synchronous ? ESAI_ECR_ETI : ESAI_ECR_ERI;
> > break;
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [EXT] Re: [PATCH V2] ASoC: fsl_esai: replace fall-through with break
2019-04-10 11:28 ` Mark Brown
@ 2019-04-11 3:09 ` S.j. Wang
0 siblings, 0 replies; 6+ messages in thread
From: S.j. Wang @ 2019-04-11 3:09 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel@alsa-project.org, timur@kernel.org,
gustavo@embeddedor.com, linuxppc-dev@lists.ozlabs.org,
Xiubo.Lee@gmail.com, nicoleotsuka@gmail.com, festevam@gmail.com
Hi Mark
>
> On Wed, Apr 10, 2019 at 02:42:45AM +0000, S.j. Wang wrote:
> > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent
> of
> > each other, so replace fall-through with break.
>
> This doesn't apply against current code, please check and resend.
Thanks, have sent v4 for update subject according to Gustavo's comments.
[PATCH V4] ASoC: fsl_esai: Fix missing break in switch statement
Best regards
Wang shengjiu
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-11 3:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-10 2:42 [PATCH V2] ASoC: fsl_esai: replace fall-through with break S.j. Wang
2019-04-10 3:53 ` Nicolin Chen
2019-04-10 11:28 ` Mark Brown
2019-04-11 3:09 ` [EXT] " S.j. Wang
2019-04-10 14:31 ` Gustavo A. R. Silva
2019-04-11 2:48 ` [EXT] " S.j. Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).