From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Joe Perches <joe@perches.com>
Cc: Tyrel Datwyler <tyreld@linux.ibm.com>,
Josh Boyer <jwboyer@kernel.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] MAINTAINERS: Update remaining @linux.vnet.ibm.com addresses
Date: Thu, 11 Apr 2019 06:12:22 -0700 [thread overview]
Message-ID: <20190411131222.GW14111@linux.ibm.com> (raw)
In-Reply-To: <921408ed6a19d9c6fed18182f03a6dac5ea42aae.camel@perches.com>
On Thu, Apr 11, 2019 at 05:27:31AM -0700, Joe Perches wrote:
> On Thu, 2019-04-11 at 22:07 +1000, Michael Ellerman wrote:
> > Joe Perches <joe@perches.com> writes:
> > > On Thu, 2019-04-11 at 06:27 +0200, Lukas Bulwahn wrote:
> > > > Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com
> > > > to @linux.ibm.com in commit 1dfddcdb95c4
> > > > ("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but
> > > > some still remained.
> > > >
> > > > We update the remaining email addresses in MAINTAINERS, hopefully finally
> > > > catching all cases for good.
> > >
> > > Perhaps update all the similar addresses in other files too
> > >
> > > $ git grep --name-only 'linux\.vnet\.ibm\.com' | wc -l
> > > 315
> >
> > A good number of them are no longer valid. So I'm not sure it's worth
> > updating them en masse to addresses that won't ever work.
> >
> > We have git now, we don't need email addresses in files, they're just
> > prone to bitrot like this.
> >
> > Should we just change them all like so?
> >
> > -arch/powerpc/boot/dts/bamboo.dts: * Josh Boyer <jwboyer@linux.vnet.ibm.com>
> > +arch/powerpc/boot/dts/bamboo.dts: * Josh Boyer (IBM)
> >
> > To indicate the author was at IBM when they wrote it?
>
> If that's desired, perhaps:
>
> $ git grep -P --name-only '<?[\w\.]+(?:@| at )linux\.vnet\.ibm\.com>?' | \
> grep -vP '\.mailmap|MAINTAINERS' | \
> xargs perl -p -i -e 's/<?[\w\.]+(?:@|\ at\ )linux\.vnet\.ibm\.com>?/(IBM)/g'
>
> > Or should we try and update them with current addresses? Though then the
> > authors might start getting mails they don't want.
>
> That'd be my preference.
>
> If authors get emails they don't want, then those contact
> emails should be removed.
I have updated most of mine, with one more installment of patches to go
into the next merge window and another into the merge window after that.
More churn than I would have expected, though. If my email address were
to change again, I would instead go with the "(IBM)" approach and let
the git log and MAINTAINERS file keep the contact information. Not that
we get to update the git log, of course. ;-)
I might not have bothered except for combining with the SPDX-tag
commits.
Thanx, Paul
next prev parent reply other threads:[~2019-04-11 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 4:27 [PATCH] MAINTAINERS: Update remaining @linux.vnet.ibm.com addresses Lukas Bulwahn
2019-04-11 11:33 ` Paul E. McKenney
2019-04-11 11:45 ` Joe Perches
2019-04-11 12:07 ` Michael Ellerman
2019-04-11 12:27 ` Joe Perches
2019-04-11 13:12 ` Paul E. McKenney [this message]
2019-04-12 16:16 ` Joe Perches
2019-04-21 14:19 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411131222.GW14111@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=joe@perches.com \
--cc=jwboyer@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas.bulwahn@gmail.com \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).