From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE2E4C43219 for ; Fri, 3 May 2019 12:14:22 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AE492075C for ; Fri, 3 May 2019 12:14:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AE492075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44wWJq3XSyzDqbk for ; Fri, 3 May 2019 22:14:19 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=bootlin.com (client-ip=217.70.178.242; helo=mslow2.mail.gandi.net; envelope-from=miquel.raynal@bootlin.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=bootlin.com Received: from mslow2.mail.gandi.net (mslow2.mail.gandi.net [217.70.178.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44wWGw4msTzDqTm for ; Fri, 3 May 2019 22:12:36 +1000 (AEST) Received: from relay11.mail.gandi.net (unknown [217.70.178.231]) by mslow2.mail.gandi.net (Postfix) with ESMTP id 6C9F73AE74E for ; Fri, 3 May 2019 11:12:26 +0000 (UTC) Received: from xps13 (aaubervilliers-681-1-29-145.w90-88.abo.wanadoo.fr [90.88.149.145]) (Authenticated sender: miquel.raynal@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 9D4FF100005; Fri, 3 May 2019 11:11:53 +0000 (UTC) Date: Fri, 3 May 2019 13:11:52 +0200 From: Miquel Raynal To: Masahiro Yamada Subject: Re: [RESEND PATCH v3 05/11] mtd: rawnand: vf610_nfc: add initializer to avoid -Wmaybe-uninitialized Message-ID: <20190503131152.57b4ce25@xps13> In-Reply-To: References: <20190423034959.13525-1-yamada.masahiro@socionext.com> <20190423034959.13525-6-yamada.masahiro@socionext.com> <20190502161346.07c15187@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Arnd Bergmann , linux-s390 , Mathieu Malaterre , X86 ML , Heiko Carstens , linux-mips@vger.kernel.org, Linux Kernel Mailing List , Ingo Molnar , linux-mtd , Andrew Morton , linuxppc-dev , linux-arm-kernel Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Masahiro, Masahiro Yamada wrote on Fri, 3 May 2019 19:36:35 +0900: > Hi Miquel, >=20 > On Thu, May 2, 2019 at 11:14 PM Miquel Raynal = wrote: > > > > Hi Masahiro, > > > > Masahiro Yamada wrote on Tue, 23 Apr > > 2019 12:49:53 +0900: > > =20 > > > This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common > > > place. We need to eliminate potential issues beforehand. > > > > > > Kbuild test robot has never reported -Wmaybe-uninitialized warning > > > for this probably because vf610_nfc_run() is inlined by the x86 > > > compiler's inlining heuristic. > > > > > > If CONFIG_OPTIMIZE_INLINING is enabled for a different architecture > > > and vf610_nfc_run() is not inlined, the following warning is reported: > > > > > > drivers/mtd/nand/raw/vf610_nfc.c: In function =E2=80=98vf610_nfc_cmd= =E2=80=99: > > > drivers/mtd/nand/raw/vf610_nfc.c:455:3: warning: =E2=80=98offset=E2= =80=99 may be used uninitialized in this function [-Wmaybe-uninitialized] > > > vf610_nfc_rd_from_sram(instr->ctx.data.buf.in + offset, > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > nfc->regs + NFC_MAIN_AREA(0) + offset, > > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > trfr_sz, !nfc->data_access); > > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~ =20 > > > > IMHO this patch has no dependencies with this series. =20 >=20 >=20 > This patch is the prerequisite for 11/11. > https://lore.kernel.org/patchwork/patch/1064959/ >=20 >=20 > Without the correct patch order, > the kbuild test robot reports the warning. >=20 >=20 > > Would you mind sending it alone with the proper Fixes tag? =20 >=20 >=20 > I do not think Fixes is necessary. IMHO it is. Even if today the warning does not spawn, there is a real C error which might already be an issue. >=20 > Nobody has noticed this potential issue before. > Without 11/11, probably we cannot reproduce this warning. >=20 >=20 > BTW, this series has been for a while in linux-next. Missed that. Ok, nevermind. Thanks, Miqu=C3=A8l