* [PATCH AUTOSEL 4.14 65/95] powerpc: remove old GCC version checks [not found] <20190507053826.31622-1-sashal@kernel.org> @ 2019-05-07 5:37 ` Sasha Levin 2019-05-07 7:52 ` Christophe Leroy 0 siblings, 1 reply; 2+ messages in thread From: Sasha Levin @ 2019-05-07 5:37 UTC (permalink / raw) To: linux-kernel, stable Cc: Sasha Levin, linuxppc-dev, Joel Stanley, Nicholas Piggin From: Nicholas Piggin <npiggin@gmail.com> [ Upstream commit f2910f0e6835339e6ce82cef22fa15718b7e3bfa ] GCC 4.6 is the minimum supported now. Signed-off-by: Nicholas Piggin <npiggin@gmail.com> Reviewed-by: Joel Stanley <joel@jms.id.au> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> --- arch/powerpc/Makefile | 31 ++----------------------------- 1 file changed, 2 insertions(+), 29 deletions(-) diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile index 7452e50f4d1f..0f04c878113e 100644 --- a/arch/powerpc/Makefile +++ b/arch/powerpc/Makefile @@ -396,36 +396,9 @@ archprepare: checkbin # to stdout and these checks are run even on install targets. TOUT := .tmp_gas_check -# Check gcc and binutils versions: -# - gcc-3.4 and binutils-2.14 are a fatal combination -# - Require gcc 4.0 or above on 64-bit -# - gcc-4.2.0 has issues compiling modules on 64-bit +# Check toolchain versions: +# - gcc-4.6 is the minimum kernel-wide version so nothing required. checkbin: - @if test "$(cc-name)" != "clang" \ - && test "$(cc-version)" = "0304" ; then \ - if ! /bin/echo mftb 5 | $(AS) -v -mppc -many -o $(TOUT) >/dev/null 2>&1 ; then \ - echo -n '*** ${VERSION}.${PATCHLEVEL} kernels no longer build '; \ - echo 'correctly with gcc-3.4 and your version of binutils.'; \ - echo '*** Please upgrade your binutils or downgrade your gcc'; \ - false; \ - fi ; \ - fi - @if test "$(cc-name)" != "clang" \ - && test "$(cc-version)" -lt "0400" \ - && test "x${CONFIG_PPC64}" = "xy" ; then \ - echo -n "Sorry, GCC v4.0 or above is required to build " ; \ - echo "the 64-bit powerpc kernel." ; \ - false ; \ - fi - @if test "$(cc-name)" != "clang" \ - && test "$(cc-fullversion)" = "040200" \ - && test "x${CONFIG_MODULES}${CONFIG_PPC64}" = "xyy" ; then \ - echo -n '*** GCC-4.2.0 cannot compile the 64-bit powerpc ' ; \ - echo 'kernel with modules enabled.' ; \ - echo -n '*** Please use a different GCC version or ' ; \ - echo 'disable kernel modules' ; \ - false ; \ - fi @if test "x${CONFIG_CPU_LITTLE_ENDIAN}" = "xy" \ && $(LD) --version | head -1 | grep ' 2\.24$$' >/dev/null ; then \ echo -n '*** binutils 2.24 miscompiles weak symbols ' ; \ -- 2.20.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH AUTOSEL 4.14 65/95] powerpc: remove old GCC version checks 2019-05-07 5:37 ` [PATCH AUTOSEL 4.14 65/95] powerpc: remove old GCC version checks Sasha Levin @ 2019-05-07 7:52 ` Christophe Leroy 0 siblings, 0 replies; 2+ messages in thread From: Christophe Leroy @ 2019-05-07 7:52 UTC (permalink / raw) To: Sasha Levin, linux-kernel, stable Cc: Sasha Levin, linuxppc-dev, Joel Stanley, Nicholas Piggin Hi Sasha, I don't think GCC 4.6 is the minimum supported for 4.14 As far as I can see, commit cafa0010cd51f ("Raise the minimum required gcc version to 4.6") has not been applied to 4.14 and I can't see any reason such a commit should apply on a stable branch. Christophe Le 07/05/2019 à 07:37, Sasha Levin a écrit : > From: Nicholas Piggin <npiggin@gmail.com> > > [ Upstream commit f2910f0e6835339e6ce82cef22fa15718b7e3bfa ] > > GCC 4.6 is the minimum supported now. > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> > Reviewed-by: Joel Stanley <joel@jms.id.au> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> > Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> > --- > arch/powerpc/Makefile | 31 ++----------------------------- > 1 file changed, 2 insertions(+), 29 deletions(-) > > diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile > index 7452e50f4d1f..0f04c878113e 100644 > --- a/arch/powerpc/Makefile > +++ b/arch/powerpc/Makefile > @@ -396,36 +396,9 @@ archprepare: checkbin > # to stdout and these checks are run even on install targets. > TOUT := .tmp_gas_check > > -# Check gcc and binutils versions: > -# - gcc-3.4 and binutils-2.14 are a fatal combination > -# - Require gcc 4.0 or above on 64-bit > -# - gcc-4.2.0 has issues compiling modules on 64-bit > +# Check toolchain versions: > +# - gcc-4.6 is the minimum kernel-wide version so nothing required. > checkbin: > - @if test "$(cc-name)" != "clang" \ > - && test "$(cc-version)" = "0304" ; then \ > - if ! /bin/echo mftb 5 | $(AS) -v -mppc -many -o $(TOUT) >/dev/null 2>&1 ; then \ > - echo -n '*** ${VERSION}.${PATCHLEVEL} kernels no longer build '; \ > - echo 'correctly with gcc-3.4 and your version of binutils.'; \ > - echo '*** Please upgrade your binutils or downgrade your gcc'; \ > - false; \ > - fi ; \ > - fi > - @if test "$(cc-name)" != "clang" \ > - && test "$(cc-version)" -lt "0400" \ > - && test "x${CONFIG_PPC64}" = "xy" ; then \ > - echo -n "Sorry, GCC v4.0 or above is required to build " ; \ > - echo "the 64-bit powerpc kernel." ; \ > - false ; \ > - fi > - @if test "$(cc-name)" != "clang" \ > - && test "$(cc-fullversion)" = "040200" \ > - && test "x${CONFIG_MODULES}${CONFIG_PPC64}" = "xyy" ; then \ > - echo -n '*** GCC-4.2.0 cannot compile the 64-bit powerpc ' ; \ > - echo 'kernel with modules enabled.' ; \ > - echo -n '*** Please use a different GCC version or ' ; \ > - echo 'disable kernel modules' ; \ > - false ; \ > - fi > @if test "x${CONFIG_CPU_LITTLE_ENDIAN}" = "xy" \ > && $(LD) --version | head -1 | grep ' 2\.24$$' >/dev/null ; then \ > echo -n '*** binutils 2.24 miscompiles weak symbols ' ; \ > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-07 7:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190507053826.31622-1-sashal@kernel.org>
2019-05-07 5:37 ` [PATCH AUTOSEL 4.14 65/95] powerpc: remove old GCC version checks Sasha Levin
2019-05-07 7:52 ` Christophe Leroy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).