From: Richard Cochran <richardcochran@gmail.com>
To: Po Liu <po.liu@nxp.com>
Cc: Roy Zang <roy.zang@nxp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leo Li <leoyang.li@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Mingkai Hu <mingkai.hu@nxp.com>, "Y.b. Lu" <yangbo.lu@nxp.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"deepa.kernel@gmail.com" <deepa.kernel@gmail.com>
Subject: Re: [EXT] Re: [PATCH v1] timer:clock:ptp: add support the dynamic posix clock alarm set for ptp
Date: Wed, 8 May 2019 10:06:29 -0700 [thread overview]
Message-ID: <20190508170629.me5smui6n7n62x2l@localhost> (raw)
In-Reply-To: <20190508143654.uj7266kcbhf744c3@localhost>
On Wed, May 08, 2019 at 07:36:54AM -0700, Richard Cochran wrote:
> No the alarm functionality has been removed. It will not be coming
> back, unless there are really strong arguments to support it.
Here is some more background:
commit 3a06c7ac24f9f24ec059cd77c2dbdf7fbfd0aaaf
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 30 23:15:38 2017 +0200
posix-clocks: Remove interval timer facility and mmap/fasync callbacks
The only user of this facility is ptp_clock, which does not implement any of
those functions.
Remove them to prevent accidental users. Especially the interval timer
interfaces are now more or less impossible to implement because the
necessary infrastructure has been confined to the core code. Aside of that
it's really complex to make these callbacks implemented according to spec
as the alarm timer implementation demonstrates. If at all then a nanosleep
callback might be a reasonable extension. For now keep just what ptp_clock
needs.
> Here is the result of a study of a prototype alarm method. It shows
> why the hrtimer method is better.
>
> https://sourceforge.net/p/linuxptp/mailman/message/35535965/
That test was with a PCIe card. With a SoC that has a PHC as a built
in peripheral, the hardware solution might outperform hrtimers.
So you might consider adding clock_nanosleep() for dynamic posix
clocks. But your code will have to support multiple users at the same
time.
Thanks,
Richard
prev parent reply other threads:[~2019-05-08 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 5:02 [PATCH v1] timer:clock:ptp: add support the dynamic posix clock alarm set for ptp Po Liu
2019-05-07 13:49 ` Richard Cochran
2019-05-08 3:30 ` [EXT] " Po Liu
2019-05-08 14:36 ` Richard Cochran
2019-05-08 17:06 ` Richard Cochran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508170629.me5smui6n7n62x2l@localhost \
--to=richardcochran@gmail.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=deepa.kernel@gmail.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingkai.hu@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=po.liu@nxp.com \
--cc=roy.zang@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).