From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Eric Piel <eric.piel@tremplin-utc.net>,
Andrew Donnellan <ajd@linux.ibm.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Frank Haverkamp <haver@linux.ibm.com>,
linux-kernel@vger.kernel.org,
Frederic Barrat <fbarrat@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] misc: remove redundant 'default n' from Kconfig-s
Date: Mon, 20 May 2019 19:55:55 +0200 [thread overview]
Message-ID: <20190520175555.GA5429@qmqm.qmqm.pl> (raw)
In-Reply-To: <1ab818ae-4d9f-d17a-f11f-7caaa5bf98bc@samsung.com>
On Mon, May 20, 2019 at 04:10:46PM +0200, Bartlomiej Zolnierkiewicz wrote:
> 'default n' is the default value for any bool or tristate Kconfig
> setting so there is no need to write it explicitly.
>
> Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> is not set' for visible symbols") the Kconfig behavior is the same
> regardless of 'default n' being present or not:
>
> ...
> One side effect of (and the main motivation for) this change is making
> the following two definitions behave exactly the same:
>
> config FOO
> bool
>
> config FOO
> bool
> default n
>
> With this change, neither of these will generate a
> '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
> That might make it clearer to people that a bare 'default n' is
> redundant.
> ...
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
[...]
> drivers/misc/cb710/Kconfig | 1 -
Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
next prev parent reply other threads:[~2019-05-20 18:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190520141047eucas1p2c6006d1ecfc3eb287b6b33d131f66180@eucas1p2.samsung.com>
2019-05-20 14:10 ` [PATCH] misc: remove redundant 'default n' from Kconfig-s Bartlomiej Zolnierkiewicz
2019-05-20 17:55 ` Michał Mirosław [this message]
2019-05-21 11:49 ` Michael Ellerman
2019-05-22 4:29 ` Frederic Barrat
2019-05-22 21:20 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520175555.GA5429@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=ajd@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=eric.piel@tremplin-utc.net \
--cc=fbarrat@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=haver@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox