From: Christoph Hellwig <hch@infradead.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: aik@ozlabs.ru, linux-kernel@vger.kernel.org,
Qian Cai <cai@lca.pw>,
paulus@samba.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/powernv: fix variable "c" set but not used
Date: Thu, 23 May 2019 00:46:54 -0700 [thread overview]
Message-ID: <20190523074654.GA9873@infradead.org> (raw)
In-Reply-To: <d0512822-ca22-75ec-3dd9-1024001632f5@c-s.fr>
On Thu, May 23, 2019 at 09:26:53AM +0200, Christophe Leroy wrote:
> You are not fixing the problem, you are just hiding it.
>
> If the result of __get_user() is unneeded, it means __get_user() is not the
> good function to use.
>
> Should use fault_in_pages_readable() instead.
Also it is not just the variable that is unused, but that whole
function. I'll resend my series to remote it in a bit.
prev parent reply other threads:[~2019-05-23 7:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 2:31 [PATCH] powerpc/powernv: fix variable "c" set but not used Qian Cai
2019-05-23 7:26 ` Christophe Leroy
2019-05-23 7:46 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523074654.GA9873@infradead.org \
--to=hch@infradead.org \
--cc=aik@ozlabs.ru \
--cc=cai@lca.pw \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).