From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95730C282CE for ; Sat, 25 May 2019 11:09:48 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10DBF2085A for ; Sat, 25 May 2019 11:09:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10DBF2085A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45B0r95m63zDqQy for ; Sat, 25 May 2019 21:09:45 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=srs0=xwpv=tz=goodmis.org=rostedt@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=goodmis.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45B0pm3mjPzDqFC for ; Sat, 25 May 2019 21:08:32 +1000 (AEST) Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B2D22085A; Sat, 25 May 2019 11:08:28 +0000 (UTC) Date: Sat, 25 May 2019 07:08:26 -0400 From: Steven Rostedt To: Joel Fernandes Subject: Re: [PATCH RFC 0/5] Remove some notrace RCU APIs Message-ID: <20190525070826.16f76ee7@gandalf.local.home> In-Reply-To: <20190525081444.GC197789@google.com> References: <20190524234933.5133-1-joel@joelfernandes.org> <20190524232458.4bcf4eb4@gandalf.local.home> <20190525081444.GC197789@google.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rcu@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Lai Jiangshan , linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, Josh Triplett , Miguel Ojeda , Ingo Molnar , Mathieu Desnoyers , "Paul E. McKenney" , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, 25 May 2019 04:14:44 -0400 Joel Fernandes wrote: > > I guess the difference between the _raw_notrace and just _raw variants > > is that _notrace ones do a rcu_check_sparse(). Don't we want to keep > > that check? > > This is true. > > Since the users of _raw_notrace are very few, is it worth keeping this API > just for sparse checking? The API naming is also confusing. I was expecting > _raw_notrace to do fewer checks than _raw, instead of more. Honestly, I just > want to nuke _raw_notrace as done in this series and later we can introduce a > sparse checking version of _raw if need-be. The other option could be to > always do sparse checking for _raw however that used to be the case and got > changed in http://lists.infradead.org/pipermail/linux-afs/2016-July/001016.html What if we just rename _raw to _raw_nocheck, and _raw_notrace to _raw ? -- Steve