From: David Gibson <david@gibson.dropbear.id.au>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
linuxppc-dev@lists.ozlabs.org,
Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Subject: Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware
Date: Tue, 4 Jun 2019 10:32:56 +1000 [thread overview]
Message-ID: <20190604003255.GA9045@umbus.fritz.box> (raw)
In-Reply-To: <20190603234932.GR31586@gate.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]
On Mon, Jun 03, 2019 at 06:49:32PM -0500, Segher Boessenkool wrote:
> On Tue, Jun 04, 2019 at 07:18:42AM +1000, Benjamin Herrenschmidt wrote:
> > Yes we could make property fetching faster but mostly by creating a new
> > bulk interface which is quite a bit of work, a new API, and will in
> > practice not be used for anything other than creating the FDT. In that
> > case, nothing will beat in performance having OF create the FDT itself
> > based on its current tree.
>
> And that will change the whole boot protocol, the interaction between OF
> and its client, which is a much bigger change, not conceptually trivial
> at all. Copying all properties at once is, which is why I suggested it.
Much as I wasn't terribly convinced by the original idea, I agree with
Ben and Alexey here. Your approach has slightly more complexity for
slightly less benefit. If it's worth doing yours it's better to do
theirs.
> It would take away the opposition to your patch.
Only from you, AFAICT...
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-06-04 2:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 3:42 [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware Alexey Kardashevskiy
2019-05-02 4:27 ` David Gibson
2019-05-03 0:10 ` Stewart Smith
2019-05-03 2:35 ` David Gibson
2019-05-06 2:21 ` Alexey Kardashevskiy
2019-05-03 15:35 ` Segher Boessenkool
2019-05-03 15:32 ` Segher Boessenkool
2019-05-30 7:09 ` Alexey Kardashevskiy
2019-05-30 19:37 ` Segher Boessenkool
2019-05-31 1:03 ` Benjamin Herrenschmidt
2019-06-02 23:23 ` Segher Boessenkool
2019-06-03 2:56 ` Alexey Kardashevskiy
2019-06-03 21:18 ` Benjamin Herrenschmidt
2019-06-03 23:49 ` Segher Boessenkool
2019-06-04 0:32 ` David Gibson [this message]
2019-06-03 23:42 ` Segher Boessenkool
2019-06-04 0:18 ` Benjamin Herrenschmidt
2019-06-04 5:00 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604003255.GA9045@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=aik@ozlabs.ru \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=segher@kernel.crashing.org \
--cc=sjitindarsingh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).