From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: mpe@ellerman.id.au
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
mikey@neuling.org, linux-kernel@vger.kernel.org,
npiggin@gmail.com, paulus@samba.org,
naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 3/5] Powerpc/hw-breakpoint: Refactor set_dawr()
Date: Tue, 18 Jun 2019 09:57:30 +0530 [thread overview]
Message-ID: <20190618042732.5582-4-ravi.bangoria@linux.ibm.com> (raw)
In-Reply-To: <20190618042732.5582-1-ravi.bangoria@linux.ibm.com>
Remove unnecessary comments. Code itself is self explanatory.
And, ISA already talks about MRD field. I Don't think we need
to re-describe it.
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
---
arch/powerpc/kernel/process.c | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index f0fbbf6a6a1f..f002d2ffff86 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -799,18 +799,11 @@ int set_dawr(struct arch_hw_breakpoint *brk)
dawr = brk->address;
- dawrx = (brk->type & (HW_BRK_TYPE_READ | HW_BRK_TYPE_WRITE)) \
- << (63 - 58); //* read/write bits */
- dawrx |= ((brk->type & (HW_BRK_TYPE_TRANSLATE)) >> 2) \
- << (63 - 59); //* translate */
- dawrx |= (brk->type & (HW_BRK_TYPE_PRIV_ALL)) \
- >> 3; //* PRIM bits */
- /* dawr length is stored in field MDR bits 48:53. Matches range in
- doublewords (64 bits) baised by -1 eg. 0b000000=1DW and
- 0b111111=64DW.
- brk->len is in bytes.
- This aligns up to double word size, shifts and does the bias.
- */
+ dawrx = (brk->type & HW_BRK_TYPE_RDWR) << (63 - 58);
+ dawrx |= ((brk->type & HW_BRK_TYPE_TRANSLATE) >> 2) << (63 - 59);
+ dawrx |= (brk->type & HW_BRK_TYPE_PRIV_ALL) >> 3;
+
+ /* brk->len is in bytes. */
mrd = ((brk->len + 7) >> 3) - 1;
dawrx |= (mrd & 0x3f) << (63 - 53);
--
2.20.1
next prev parent reply other threads:[~2019-06-18 4:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 4:27 [PATCH 0/5] Powerpc/hw-breakpoint: Fixes plus Code refactor Ravi Bangoria
2019-06-18 4:27 ` [PATCH 1/5] Powerpc/hw-breakpoint: Replace stale do_dabr() with do_break() Ravi Bangoria
2019-06-18 6:02 ` Michael Neuling
2019-06-18 6:14 ` Christophe Leroy
2019-06-18 4:27 ` [PATCH 2/5] Powerpc/hw-breakpoint: Refactor hw_breakpoint_arch_parse() Ravi Bangoria
2019-06-18 6:21 ` Christophe Leroy
2019-06-18 7:10 ` Ravi Bangoria
2019-06-18 4:27 ` Ravi Bangoria [this message]
2019-06-18 6:11 ` [PATCH 3/5] Powerpc/hw-breakpoint: Refactor set_dawr() Michael Neuling
2019-06-18 7:13 ` Ravi Bangoria
2019-06-18 6:24 ` Christophe Leroy
2019-06-18 4:27 ` [PATCH 4/5] Powerpc/hw-breakpoint: Optimize disable path Ravi Bangoria
2019-06-18 6:15 ` Michael Neuling
2019-06-19 6:02 ` Ravi Bangoria
2019-06-18 6:31 ` Christophe Leroy
2019-06-19 6:14 ` Ravi Bangoria
2019-06-18 4:27 ` [PATCH 5/5] Powerpc/Watchpoint: Fix length calculation for unaligned target Ravi Bangoria
2019-06-18 6:46 ` Christophe Leroy
2019-06-19 6:51 ` Ravi Bangoria
2019-06-18 13:32 ` Michael Neuling
2019-06-19 7:45 ` Ravi Bangoria
2019-06-18 6:01 ` [PATCH 0/5] Powerpc/hw-breakpoint: Fixes plus Code refactor Christophe Leroy
2019-06-18 6:17 ` Michael Neuling
2019-06-19 7:47 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618042732.5582-4-ravi.bangoria@linux.ibm.com \
--to=ravi.bangoria@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).