From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C34D2C43613 for ; Fri, 21 Jun 2019 13:52:09 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 473A0206B7 for ; Fri, 21 Jun 2019 13:52:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="IKvWFo0f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 473A0206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45Vg9228HnzDqdv for ; Fri, 21 Jun 2019 23:52:06 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=ziepe.ca (client-ip=2607:f8b0:4864:20::742; helo=mail-qk1-x742.google.com; envelope-from=jgg@ziepe.ca; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=ziepe.ca header.i=@ziepe.ca header.b="IKvWFo0f"; dkim-atps=neutral Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45Vg1W6rf9zDqHR for ; Fri, 21 Jun 2019 23:45:34 +1000 (AEST) Received: by mail-qk1-x742.google.com with SMTP id b18so4408918qkc.9 for ; Fri, 21 Jun 2019 06:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5X0rmkRC95nceR2b+WbG0Q+b41qnJ7FNz5RDX36KkRU=; b=IKvWFo0f0mTVaCe/ijJtv0mDxHgoNp8HulNuI0gdobye37WUW94nv8DO7J1ctBzM/s y1U3xE4o3pFMYs/7BSYNHk45TVTdOg5ah1B/Ezb+sYysR+frntFucIE6z4FaKjp7+kPS CWfRQXI0wAV8/s5+T6lJtOeXR69gDXp75nl/bDlVvB0CS61j1/DQcB5+JxxW8c8h8L/W Do9nWLXeCDBlSBMAgLef2HJyHbQwTzNWgF989V9+FjYpu72cru6fLYnt32uoCsfDkKYD 8v1BgRCJXKFONlNlM8ZrySrf2ZWJIGMy+aVFl4b0JnDL684iSD+C68Fqbqka+ZNuPT7s EMwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5X0rmkRC95nceR2b+WbG0Q+b41qnJ7FNz5RDX36KkRU=; b=ca4u4tKY2iB/chLyUNFz01K6uFDCCrMS+VjrDFufcFuPC7VNYVcBWIgeZQO3n8oIO7 mc5OnM+4cfJRGmn87yEHINnTlV+8ffNGFgoYkRLS5eorK+1QHSYUDzZEt6w2UAyjrVAU PsmKNrp/E7uI2XY7zBU+adxoCDq2FcgNmmkCT99fFuR2/Y3+umhCYVXGTWgH0EBZiPOe jJ5S+HubteneI1ZuA2cSVfxGkC9bBO1IGjYA8KUROg0oskDbdUl6ucHyoliXUPNaEPcn ILZjCebkn6HQeAsNE77O2GXvrD2R5zevVoDpemsXaWMB8lXn6r1azIbK9MX3ZIoQ43qQ 3Wfg== X-Gm-Message-State: APjAAAWDF7X0PYkz93xuiUc54eC3CAtE4KmXmc0axhICmtnElknt673o 7YBftzY0eYCUplqIiW8obI5hlg== X-Google-Smtp-Source: APXvYqw6Aa1vtmaoAcmmWYgjcUlAuKLWmpTyuJq4yf3HeH8qCqVB5lh6+d5sgipawN8uf35W8F5eHQ== X-Received: by 2002:a37:6808:: with SMTP id d8mr5468961qkc.478.1561124732220; Fri, 21 Jun 2019 06:45:32 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id h4sm1369861qkk.39.2019.06.21.06.45.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Jun 2019 06:45:31 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1heJr9-00008q-7e; Fri, 21 Jun 2019 10:45:31 -0300 Date: Fri, 21 Jun 2019 10:45:31 -0300 From: Jason Gunthorpe To: Christoph Hellwig Subject: Re: [PATCH 03/16] mm: lift the x86_32 PAE version of gup_get_pte to common code Message-ID: <20190621134531.GN19891@ziepe.ca> References: <20190611144102.8848-1-hch@lst.de> <20190611144102.8848-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190611144102.8848-4-hch@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, Rich Felker , Yoshinori Sato , linux-sh@vger.kernel.org, James Hogan , linuxppc-dev@lists.ozlabs.org, Khalid Aziz , Nicholas Piggin , linux-mips@vger.kernel.org, linux-mm@kvack.org, Paul Burton , Paul Mackerras , Andrey Konovalov , sparclinux@vger.kernel.org, Linus Torvalds , "David S. Miller" , linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jun 11, 2019 at 04:40:49PM +0200, Christoph Hellwig wrote: > The split low/high access is the only non-READ_ONCE version of > gup_get_pte that did show up in the various arch implemenations. > Lift it to common code and drop the ifdef based arch override. > > Signed-off-by: Christoph Hellwig > --- > arch/x86/Kconfig | 1 + > arch/x86/include/asm/pgtable-3level.h | 47 ------------------------ > arch/x86/kvm/mmu.c | 2 +- > mm/Kconfig | 3 ++ > mm/gup.c | 51 ++++++++++++++++++++++++--- > 5 files changed, 52 insertions(+), 52 deletions(-) Yep, the sh and mips conversions look right too. Reviewed-by: Jason Gunthorpe > diff --git a/mm/Kconfig b/mm/Kconfig > index f0c76ba47695..fe51f104a9e0 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -762,6 +762,9 @@ config GUP_BENCHMARK > > See tools/testing/selftests/vm/gup_benchmark.c > > +config GUP_GET_PTE_LOW_HIGH > + bool > + The config name seems a bit out of place though, should it be prefixed with GENERIC_ or ARCH_? Jason