From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF00BC4646B for ; Wed, 26 Jun 2019 05:53:56 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D313208CB for ; Wed, 26 Jun 2019 05:53:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D313208CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45YXJy5TfMzDqX9 for ; Wed, 26 Jun 2019 15:53:54 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=newverein.lst.de; envelope-from=hch@lst.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lst.de Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45YXDj2WG4zDqVn for ; Wed, 26 Jun 2019 15:50:10 +1000 (AEST) Received: by newverein.lst.de (Postfix, from userid 2407) id 1443D68B05; Wed, 26 Jun 2019 07:49:35 +0200 (CEST) Date: Wed, 26 Jun 2019 07:49:34 +0200 From: Christoph Hellwig To: Andrew Morton Subject: Re: [PATCH 14/16] mm: move the powerpc hugepd code to mm/gup.c Message-ID: <20190626054934.GA23547@lst.de> References: <20190625143715.1689-1-hch@lst.de> <20190625143715.1689-15-hch@lst.de> <20190625123757.ec7e886747bb5a9bc364107d@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190625123757.ec7e886747bb5a9bc364107d@linux-foundation.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, Rich Felker , Yoshinori Sato , linux-sh@vger.kernel.org, James Hogan , linuxppc-dev@lists.ozlabs.org, Khalid Aziz , Nicholas Piggin , "David S. Miller" , linux-mm@kvack.org, Paul Burton , Paul Mackerras , Andrey Konovalov , sparclinux@vger.kernel.org, linux-mips@vger.kernel.org, Linus Torvalds , Christoph Hellwig , linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jun 25, 2019 at 12:37:57PM -0700, Andrew Morton wrote: > On Tue, 25 Jun 2019 16:37:13 +0200 Christoph Hellwig wrote: > > > +static int gup_huge_pd(hugepd_t hugepd > > Naming nitlet: we have hugepd and we also have huge_pd. We have > hugepte and we also have huge_pte. It make things a bit hard to > remember and it would be nice to make it all consistent sometime. > > We're consistent with huge_pud and almost consistent with huge_pmd. > > To be fully consistent I guess we should make all of them have the > underscore. Or not have it. Either way is fine with me. Feel free to fix up per your preference.