From: Christoph Hellwig <hch@lst.de>
To: Mark Greer <mgreer@animalcreek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-serial@vger.kernel.org,
Dale Farnsworth <dale@farnsworth.org>,
linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>
Subject: Re: DMA coherency in drivers/tty/serial/mpsc.c
Date: Wed, 26 Jun 2019 08:48:37 +0200 [thread overview]
Message-ID: <20190626064837.GA24531@lst.de> (raw)
In-Reply-To: <20190625163722.GA18626@animalcreek.com>
On Tue, Jun 25, 2019 at 09:37:22AM -0700, Mark Greer wrote:
> Yeah, the mpsc driver had lots of ugly cache related hacks because of
> cache coherency bugs in the early version of the MV64x60 bridge chips
> that it was embedded in. That chip is pretty much dead now and I've
> removed core support for it from the powerpc tree. Removing the mpsc
> driver is on my todo list but I've been busy and lazy. So, to sum it
> up, don't spend any more time worrying about it as it should be removed.
>
> I'll post a patch to do that tonight and I'm sorry for any time you've
> spent looking at it so far.
No problem. And if future such broken chips show up we now have
support for per-device DMA coherency settings and could actually
handle it in a reaѕonably clean way.
next prev parent reply other threads:[~2019-06-26 6:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 12:26 DMA coherency in drivers/tty/serial/mpsc.c Christoph Hellwig
2019-06-25 16:37 ` Mark Greer
2019-06-26 6:48 ` Christoph Hellwig [this message]
2019-06-26 16:09 ` Mark Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626064837.GA24531@lst.de \
--to=hch@lst.de \
--cc=dale@farnsworth.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mgreer@animalcreek.com \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).