* [PATCH 1/2] powerpc/pseries/mobility: set pr_fmt
2019-06-27 5:30 [PATCH 0/2] migration/prrn instrumentation tweaks Nathan Lynch
@ 2019-06-27 5:30 ` Nathan Lynch
2019-06-27 5:30 ` [PATCH 2/2] powerpc/pseries/mobility: add pr_debug for device tree changes Nathan Lynch
2020-08-02 13:35 ` [PATCH 0/2] migration/prrn instrumentation tweaks Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Nathan Lynch @ 2019-06-27 5:30 UTC (permalink / raw)
To: linuxppc-dev
The pr_err callsites in mobility.c already manually include a
"mobility:" prefix, let's make it official for the benefit of messages
to be added later.
Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
---
arch/powerpc/platforms/pseries/mobility.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c
index b8c8096907d4..f9a1287925a8 100644
--- a/arch/powerpc/platforms/pseries/mobility.c
+++ b/arch/powerpc/platforms/pseries/mobility.c
@@ -9,6 +9,9 @@
* 2 as published by the Free Software Foundation.
*/
+
+#define pr_fmt(fmt) "mobility: " fmt
+
#include <linux/cpu.h>
#include <linux/kernel.h>
#include <linux/kobject.h>
@@ -418,11 +421,11 @@ static int __init mobility_sysfs_init(void)
rc = sysfs_create_file(mobility_kobj, &class_attr_migration.attr);
if (rc)
- pr_err("mobility: unable to create migration sysfs file (%d)\n", rc);
+ pr_err("unable to create migration sysfs file (%d)\n", rc);
rc = sysfs_create_file(mobility_kobj, &class_attr_api_version.attr.attr);
if (rc)
- pr_err("mobility: unable to create api_version sysfs file (%d)\n", rc);
+ pr_err("unable to create api_version sysfs file (%d)\n", rc);
return 0;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] powerpc/pseries/mobility: add pr_debug for device tree changes
2019-06-27 5:30 [PATCH 0/2] migration/prrn instrumentation tweaks Nathan Lynch
2019-06-27 5:30 ` [PATCH 1/2] powerpc/pseries/mobility: set pr_fmt Nathan Lynch
@ 2019-06-27 5:30 ` Nathan Lynch
2020-08-02 13:35 ` [PATCH 0/2] migration/prrn instrumentation tweaks Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Nathan Lynch @ 2019-06-27 5:30 UTC (permalink / raw)
To: linuxppc-dev
When investigating issues with partition migration or resource
reassignments it is helpful to have a log of which nodes and
properties in the device tree have changed. Use pr_debug() so it's
easy to enable these at runtime with the dynamic debug facility.
Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
---
arch/powerpc/platforms/pseries/mobility.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c
index f9a1287925a8..5270ac00279b 100644
--- a/arch/powerpc/platforms/pseries/mobility.c
+++ b/arch/powerpc/platforms/pseries/mobility.c
@@ -69,6 +69,8 @@ static int delete_dt_node(__be32 phandle)
if (!dn)
return -ENOENT;
+ pr_debug("removing node %pOFfp\n", dn);
+
dlpar_detach_node(dn);
of_node_put(dn);
return 0;
@@ -127,6 +129,7 @@ static int update_dt_property(struct device_node *dn, struct property **prop,
}
if (!more) {
+ pr_debug("updating node %pOF property %s\n", dn, name);
of_update_property(dn, new_prop);
*prop = NULL;
}
@@ -241,6 +244,8 @@ static int add_dt_node(__be32 parent_phandle, __be32 drc_index)
if (rc)
dlpar_free_cc_nodes(dn);
+ pr_debug("added node %pOFfp\n", dn);
+
of_node_put(parent_dn);
return rc;
}
@@ -256,6 +261,7 @@ static void prrn_update_node(__be32 phandle)
*/
dn = of_find_node_by_phandle(be32_to_cpu(phandle));
if (dn) {
+ pr_debug("ignoring PRRN for %pOFfp\n", dn);
of_node_put(dn);
return;
}
@@ -265,6 +271,8 @@ static void prrn_update_node(__be32 phandle)
hp_elog.id_type = PSERIES_HP_ELOG_ID_DRC_INDEX;
hp_elog._drc_u.drc_index = phandle;
+ pr_debug("handling PRRN for LMB DRC index 0x%x\n", be32_to_cpu(phandle));
+
handle_dlpar_errorlog(&hp_elog);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread