From: <wen.yang99@zte.com.cn>
To: <viresh.kumar@linaro.org>
Cc: wang.yi59@zte.com.cn, linux-pm@vger.kernel.org,
rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
xue.zhihong@zte.com.cn, cheng.shengyu@zte.com.cn,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] cpufreq/pasemi: fix an use-after-free inpas_cpufreq_cpu_init()
Date: Mon, 8 Jul 2019 15:03:57 +0800 (CST) [thread overview]
Message-ID: <201907081503576413750@zte.com.cn> (raw)
In-Reply-To: <20190708062708.5zufqsmgso436idn@vireshk-i7>
[-- Attachment #1.1: Type: text/plain, Size: 745 bytes --]
> > The cpu variable is still being used in the of_get_property() call
> > after the of_node_put() call, which may result in use-after-free.
> >
> > Fixes: a9acc26b75f ("cpufreq/pasemi: fix possible object reference leak")
> > Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > Cc: linuxppc-dev@lists.ozlabs.org
> > Cc: linux-pm@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > ---
> > drivers/cpufreq/pasemi-cpufreq.c | 10 ++++++----
> > 1 file changed, 6 insertions(+), 4 deletions(-)
>
> I will suggest some changes here.
Hello viresh, thank you for your comments.
We will make changes as soon as possible.
--
Thanks and regards,
Wen
prev parent reply other threads:[~2019-07-08 7:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 6:19 [PATCH] cpufreq/pasemi: fix an use-after-free in pas_cpufreq_cpu_init() Wen Yang
2019-07-08 6:27 ` Viresh Kumar
2019-07-08 7:03 ` wen.yang99 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201907081503576413750@zte.com.cn \
--to=wen.yang99@zte.com.cn \
--cc=cheng.shengyu@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox