From: Sven Schnelle <svens@stackframe.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: linuxppc-dev@lists.ozlabs.org, deller@gmx.de, kexec@lists.infradead.org
Subject: Re: [PATCH using git format-patch -C] kexec: add generic support for elf kernel images
Date: Mon, 8 Jul 2019 19:51:39 +0200 [thread overview]
Message-ID: <20190708175139.GA11402@t470p.stackframe.org> (raw)
In-Reply-To: <e016c0bb-c857-b78c-a159-120e42d0db03@c-s.fr>
Hi Christophe,
On Mon, Jul 08, 2019 at 12:40:52PM +0200, Christophe Leroy wrote:
> > From: Sven Schnelle <svens@stackframe.org>
>
> Please describe you patch.
>
> All the changes you are doing to the ppc64 version in order to make it
> generic should be described.
>
> Those changes are also maybe worth splitting the patch in several parts,
> either preparing the ppc64 for generic then moving to kernel/kexec_elf.c or
> moving to kernel/kexec_elf.c without modifications, then modifying it to
> make it generic.
>
> Note that your patch only applies on Linux 5.1, it doesn't apply on
> powerpc/next.
>
> I think it also be worth taking the opportunity to fix the sparse warnings,
> see https://patchwork.ozlabs.org/patch/1128720/
>
> checkpatch comments should also be fixed, see https://openpower.xyz/job/snowpatch/job/snowpatch-linux-checkpatch/8044//artifact/linux/checkpatch.log
Actually this patch shouldn't have been sent out, that was my fault. Appologies
for that. Thanks for your review, i will split up the patch and resent it.
Regards
Sven
next prev parent reply other threads:[~2019-07-08 17:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 10:06 [PATCH using git format-patch -C] kexec: add generic support for elf kernel images Christophe Leroy
2019-07-08 10:40 ` Christophe Leroy
2019-07-08 17:51 ` Sven Schnelle [this message]
2019-07-09 4:19 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708175139.GA11402@t470p.stackframe.org \
--to=svens@stackframe.org \
--cc=christophe.leroy@c-s.fr \
--cc=deller@gmx.de \
--cc=kexec@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).