From: Christoph Hellwig <hch@infradead.org>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: Sachin Sant <sachinp@linux.vnet.ibm.com>,
Michal Suchanek <msuchanek@suse.de>,
Nayna Jain <nayna@linux.ibm.com>,
linux-kernel@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Christoph Hellwig <hch@infradead.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org,
George Wilson <gcwilson@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, Peter Huewe <peterhuewe@gmx.de>
Subject: Re: [PATCH v2] tpm: tpm_ibm_vtpm: Fix unallocated banks
Date: Mon, 8 Jul 2019 15:43:04 -0700 [thread overview]
Message-ID: <20190708224304.GA25838@infradead.org> (raw)
In-Reply-To: <1562624644.11461.66.camel@linux.ibm.com>
On Mon, Jul 08, 2019 at 06:24:04PM -0400, Mimi Zohar wrote:
> > static int tpm_get_pcr_allocation(struct tpm_chip *chip)
> > {
> > int rc;
> >
> > rc = (chip->flags & TPM_CHIP_FLAG_TPM2) ?
> > tpm2_get_pcr_allocation(chip) :
> > tpm1_get_pcr_allocation(chip);
>
> >
> > return rc > 0 ? -ENODEV : rc;
> > }
> >
> > This addresses the issue that Stefan also pointed out. You have to
> > deal with the TPM error codes.
>
> Hm, in the past I was told by Christoph not to use the ternary
> operator. Have things changed? Other than removing the comment, the
> only other difference is the return.
In the end it is a matter of personal preference, but I find the
quote version above using the ternary horribly obsfucated.
next prev parent reply other threads:[~2019-07-08 22:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-07 0:18 [PATCH v2] tpm: tpm_ibm_vtpm: Fix unallocated banks Nayna Jain
2019-07-08 0:25 ` Stefan Berger
2019-07-08 15:11 ` Jarkko Sakkinen
2019-07-08 22:24 ` Mimi Zohar
2019-07-08 22:43 ` Christoph Hellwig [this message]
2019-07-09 16:38 ` Jarkko Sakkinen
2019-07-11 17:59 ` Nayna
2019-07-08 22:53 ` Jason Gunthorpe
2019-07-09 16:35 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708224304.GA25838@infradead.org \
--to=hch@infradead.org \
--cc=gcwilson@linux.ibm.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=msuchanek@suse.de \
--cc=nayna@linux.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=sachinp@linux.vnet.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).