From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05FF2C73C41 for ; Tue, 9 Jul 2019 14:03:07 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6456520861 for ; Tue, 9 Jul 2019 14:03:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6456520861 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45jkYL4nLtzDqKg for ; Wed, 10 Jul 2019 00:03:02 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lst.de Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45jkTW2Z24zDqWK for ; Tue, 9 Jul 2019 23:59:41 +1000 (AEST) Received: by verein.lst.de (Postfix, from userid 2407) id BEFA968B02; Tue, 9 Jul 2019 15:59:35 +0200 (CEST) Date: Tue, 9 Jul 2019 15:59:35 +0200 From: Christoph Hellwig To: Max Gurtovoy Subject: Re: [PATCH 1/3] powerpc/powernv: remove the unused pnv_pci_set_p2p function Message-ID: <20190709135935.GA2511@lst.de> References: <20190426124917.23789-1-hch@lst.de> <20190426124917.23789-2-hch@lst.de> <99c4c4a9-8a18-61ed-174a-9ffaec3d2e44@linux.ibm.com> <20190523075253.GA12946@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "'gregkh@linuxfoundation.org'" , Shlomi Nimrodi , Paul Mackerras , Frederic Barrat , Oren Duer , Idan Werpoler , "linuxppc-dev@lists.ozlabs.org" , Christoph Hellwig Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jul 09, 2019 at 01:49:04PM +0000, Max Gurtovoy wrote: > Hi Greg/Christoph, > Can we leave it meanwhile till we'll find a general solution (for the upcoming kernel) ? > I guess we can somehow generalize the P2P initialization process for PPC and leave it empty for now for other archs. > Or maybe we can find some other solution (sysfs/configfs/module param), but it will take time since we'll need to work closely with the IBM pci guys that wrote this code. We do not keep code without in-tree users around, especially not if we have a better API with in-tree users. AFAICS the only thing you'll need is to wire up the enable/disable calls.