From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: "'gregkh@linuxfoundation.org'" <gregkh@linuxfoundation.org>,
Shlomi Nimrodi <shlomin@mellanox.com>,
Paul Mackerras <paulus@samba.org>,
Bodong Wang <bodong@mellanox.com>,
Frederic Barrat <fbarrat@linux.ibm.com>,
Oren Duer <oren@mellanox.com>, Idan Werpoler <Idanw@mellanox.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/3] powerpc/powernv: remove the unused pnv_pci_set_p2p function
Date: Tue, 9 Jul 2019 17:08:53 +0200 [thread overview]
Message-ID: <20190709150853.GA3872@lst.de> (raw)
In-Reply-To: <14dee448-94bc-aaea-3661-baa92ac8c2f8@mellanox.com>
On Tue, Jul 09, 2019 at 06:06:54PM +0300, Max Gurtovoy wrote:
> Also this code was merged before the p2p API for p2pmem.
Yes, without a single user or intention to submit a user, and without
covering the most useful use case (PCIe switches). While at the same
time the people involved completely ignored the PCIe P2P discussions
that have been going on the PCI list for a long time.
This is a text book example of why code needs to be upstream first
with a broad discussion instead of slipping some crap in for out
of tree drivers.
next prev parent reply other threads:[~2019-07-09 15:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 12:49 remove dead powernv code Christoph Hellwig
2019-04-26 12:49 ` [PATCH 1/3] powerpc/powernv: remove the unused pnv_pci_set_p2p function Christoph Hellwig
2019-05-06 8:46 ` Frederic Barrat
2019-05-06 9:02 ` Christoph Hellwig
2019-05-23 7:52 ` Christoph Hellwig
2019-07-09 13:49 ` Max Gurtovoy
2019-07-09 13:59 ` Christoph Hellwig
2019-07-09 14:31 ` Max Gurtovoy
2019-07-09 14:32 ` Christoph Hellwig
2019-07-09 14:37 ` Max Gurtovoy
2019-07-09 14:40 ` Christoph Hellwig
2019-07-09 15:06 ` Max Gurtovoy
2019-07-09 15:08 ` Christoph Hellwig [this message]
2019-07-09 20:02 ` 'gregkh@linuxfoundation.org'
2019-04-26 12:49 ` [PATCH 2/3] powerpc/powernv: remove pnv_pci_{enable,disable}_tunnel Christoph Hellwig
2019-04-26 12:49 ` [PATCH 3/3] powerpc/powernv: remove dead NPU DMA code Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709150853.GA3872@lst.de \
--to=hch@lst.de \
--cc=Idanw@mellanox.com \
--cc=bodong@mellanox.com \
--cc=fbarrat@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maxg@mellanox.com \
--cc=oren@mellanox.com \
--cc=paulus@samba.org \
--cc=shlomin@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).