From: Christoph Hellwig <hch@infradead.org>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Sam Bobroff <sbobroff@linux.ibm.com>,
Alistair Popple <alistair@popple.id.au>,
Oliver O'Halloran <oohall@gmail.com>,
linuxppc-dev@lists.ozlabs.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH kernel v4 4/4] powerpc/powernv/ioda2: Create bigger default window with 64k IOMMU pages
Date: Fri, 12 Jul 2019 08:25:49 -0700 [thread overview]
Message-ID: <20190712152549.GB3061@infradead.org> (raw)
In-Reply-To: <20190712094509.56695-5-aik@ozlabs.ru>
> -extern struct iommu_table *iommu_init_table(struct iommu_table * tbl,
> - int nid);
> +extern struct iommu_table *iommu_init_table_res(struct iommu_table *tbl,
> + int nid, unsigned long res_start, unsigned long res_end);
> +#define iommu_init_table(tbl, nid) iommu_init_table_res((tbl), (nid), 0, 0)
I'd just pass the two additional paramters to iommu_init_table, there
are only 10 callers of it.
> + * the max order of allocation possible. The TCE tableis likely to
Missing whitespace between tabke and is.
> + * end up being multilevel and with on-demand allocation in place,
> + * the initial use is not going to be huge as the default window aims
> + * to support cripplied devices (i.e. not fully 64bit DMAble) only.
s/cripplied/crippled/
next prev parent reply other threads:[~2019-07-12 15:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 9:45 [PATCH kernel v4 0/4 repost] powerpc/ioda2: Yet another attempt to allow DMA masks between 32 and 59 Alexey Kardashevskiy
2019-07-12 9:45 ` [PATCH kernel v4 1/4] powerpc/powernv/ioda: Fix race in TCE level allocation Alexey Kardashevskiy
2019-07-12 9:45 ` [PATCH kernel v4 2/4] powerpc/iommu: Allow bypass-only for DMA Alexey Kardashevskiy
2019-07-12 15:20 ` Christoph Hellwig
2019-07-15 8:33 ` Alexey Kardashevskiy
2019-07-15 12:35 ` Christoph Hellwig
2019-07-12 9:45 ` [PATCH kernel v4 3/4] powerpc/powernv/ioda2: Allocate TCE table levels on demand for default DMA window Alexey Kardashevskiy
2019-07-12 9:45 ` [PATCH kernel v4 4/4] powerpc/powernv/ioda2: Create bigger default window with 64k IOMMU pages Alexey Kardashevskiy
2019-07-12 15:25 ` Christoph Hellwig [this message]
2019-07-12 15:28 ` [PATCH kernel v4 0/4 repost] powerpc/ioda2: Yet another attempt to allow DMA masks between 32 and 59 Christoph Hellwig
2019-07-15 8:43 ` Alexey Kardashevskiy
2019-07-15 12:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712152549.GB3061@infradead.org \
--to=hch@infradead.org \
--cc=aik@ozlabs.ru \
--cc=alistair@popple.id.au \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
--cc=sbobroff@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).