* [PATCH v2] crypto: nx: nx-842-powernv: Add of_node_put() before return
@ 2019-07-24 7:54 Nishka Dasgupta
2019-08-02 4:55 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Nishka Dasgupta @ 2019-07-24 7:54 UTC (permalink / raw)
To: haren, herbert, davem, benh, paulus, mpe, linux-crypto,
linuxppc-dev
Cc: Nishka Dasgupta
Each iteration of for_each_compatible_node puts the previous node, but
in the case of a return from the middle of the loop, there is no put,
thus causing a memory leak. Add an of_node_put before the return.
Issue found with Coccinelle.
Acked-by: Stewart Smith <stewart@linux.ibm.com>
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
Changes in v2:
- Fixed commit message to match the loop in question.
drivers/crypto/nx/nx-842-powernv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/nx/nx-842-powernv.c b/drivers/crypto/nx/nx-842-powernv.c
index e78ff5c65ed6..c037a2403b82 100644
--- a/drivers/crypto/nx/nx-842-powernv.c
+++ b/drivers/crypto/nx/nx-842-powernv.c
@@ -1020,6 +1020,7 @@ static __init int nx842_powernv_init(void)
ret = nx842_powernv_probe_vas(dn);
if (ret) {
nx842_delete_coprocs();
+ of_node_put(dn);
return ret;
}
}
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] crypto: nx: nx-842-powernv: Add of_node_put() before return
2019-07-24 7:54 [PATCH v2] crypto: nx: nx-842-powernv: Add of_node_put() before return Nishka Dasgupta
@ 2019-08-02 4:55 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2019-08-02 4:55 UTC (permalink / raw)
To: Nishka Dasgupta; +Cc: paulus, linux-crypto, linuxppc-dev, davem
On Wed, Jul 24, 2019 at 01:24:33PM +0530, Nishka Dasgupta wrote:
> Each iteration of for_each_compatible_node puts the previous node, but
> in the case of a return from the middle of the loop, there is no put,
> thus causing a memory leak. Add an of_node_put before the return.
> Issue found with Coccinelle.
>
> Acked-by: Stewart Smith <stewart@linux.ibm.com>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>
> ---
> Changes in v2:
> - Fixed commit message to match the loop in question.
>
> drivers/crypto/nx/nx-842-powernv.c | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-02 4:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-24 7:54 [PATCH v2] crypto: nx: nx-842-powernv: Add of_node_put() before return Nishka Dasgupta
2019-08-02 4:55 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).