From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39325C433FF for ; Wed, 7 Aug 2019 01:33:34 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76F8F2173C for ; Wed, 7 Aug 2019 01:33:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F4m9knoh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76F8F2173C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 463DY55yyczDr1Z for ; Wed, 7 Aug 2019 11:33:29 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::b44; helo=mail-yb1-xb44.google.com; envelope-from=leo.yan@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="F4m9knoh"; dkim-atps=neutral Received: from mail-yb1-xb44.google.com (mail-yb1-xb44.google.com [IPv6:2607:f8b0:4864:20::b44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 463DWG1rlJzDqhF for ; Wed, 7 Aug 2019 11:31:53 +1000 (AEST) Received: by mail-yb1-xb44.google.com with SMTP id j199so31492993ybg.5 for ; Tue, 06 Aug 2019 18:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=T+sIdUCYVl9gdRoUkUG8PgRAt1MU+/JJSzC8cSPoyKI=; b=F4m9knohPlyqe6iRBIqFogCxSMnpxfTnrNWZCR9yxgbB7jxuwk5G49Fr3Yk/Xw8ml9 BZedneP/R5GsmdKW1zaP8a4d6U9JK6r3soeGP9+77jQo83aNdUFu0Pg6auBFzgfb745n qZmIri2k5kirqo1rqRPqFtkeh+UaJ+gxE46qehbsLCBwyMGNAb4LzWNxxchylTugTGzF wLgGzWBtDpvrUKQxeBDO2XcdIgDVq4u0XiNjVcNspdW/kjB7dA7kKn81qOuPuEq5vT9D CCLS3aa+sHxb6m2tFFPS/rslez9LrTny5DfBMNa9fxii55Xz7IiwhaDAn2k/m6Tso2Db 5r3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=T+sIdUCYVl9gdRoUkUG8PgRAt1MU+/JJSzC8cSPoyKI=; b=kopYo24pZBhXghaGtr5QSV6Lnupz0z5K5oud1gqrm3zZZ0mzuBoJqGaYrN1TbR4+f8 Vm3IJOAqlFttF9IKo1Xq+13Jin52JAE2gYUJephdKsPQ9cV5d8TTDzN6JTwzo2pTFyhE E1YNfJQ8wtuIRHPOwCjosL/d5ZxFdqnPSeymLaf9h+Ne+LBc5pcpLBj+tQXEtnO6jxXx JYIpre/m8AUlmEbRuWjykDZ7nDHwysbfRKGo2j+MZ5TJ280tFiJBFvvXix0YKb3diHQ5 y0627TyuFjIJJh2R/IQmf7vTvF0LYVP2zim6Lkuhj/smiOCM3HeauQUFzZ6xhwrsSGSJ KGeA== X-Gm-Message-State: APjAAAVdQH9C2J4UrJNSV/TDzP/1cG6rzzK9IHfdyw4hzHyASffRkSmD c/pElcdEHtOawOxkQ2ys3+9iFw== X-Google-Smtp-Source: APXvYqwBSZkykF5JBW3dZ2JAWQGnqKUHEgflynlYlJTG89ph5DdcJK1w1FbC6oyDXFDuWZCqly8qmQ== X-Received: by 2002:a25:5986:: with SMTP id n128mr4697126ybb.301.1565141510026; Tue, 06 Aug 2019 18:31:50 -0700 (PDT) Received: from leoy-ThinkPad-X240s (li1322-146.members.linode.com. [45.79.223.146]) by smtp.gmail.com with ESMTPSA id k20sm20014855ywm.106.2019.08.06.18.31.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Aug 2019 18:31:49 -0700 (PDT) Date: Wed, 7 Aug 2019 09:31:39 +0800 From: Leo Yan To: Masami Hiramatsu Subject: Re: [PATCH v2 0/3] arm/arm64: Add support for function error injection Message-ID: <20190807013139.GB6724@leoy-ThinkPad-X240s> References: <20190806100015.11256-1-leo.yan@linaro.org> <20190807090811.1e50eb3e1d5a7b85743748e7@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190807090811.1e50eb3e1d5a7b85743748e7@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , Catalin Marinas , Alexei Starovoitov , Oleg Nesterov , Paul Mackerras , "H. Peter Anvin" , Will Deacon , linux-arch@vger.kernel.org, Daniel Borkmann , x86@kernel.org, Russell King , clang-built-linux@googlegroups.com, Ingo Molnar , Yonghong Song , "Naveen N. Rao" , Arnd Bergmann , Borislav Petkov , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Martin KaFai Lau Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Aug 07, 2019 at 09:08:11AM +0900, Masami Hiramatsu wrote: > On Tue, 6 Aug 2019 18:00:12 +0800 > Leo Yan wrote: > > > This small patch set is to add support for function error injection; > > this can be used to eanble more advanced debugging feature, e.g. > > CONFIG_BPF_KPROBE_OVERRIDE. > > > > The patch 01/03 is to consolidate the function definition which can be > > suared cross architectures, patches 02,03/03 are used for enabling > > function error injection on arm64 and arm architecture respectively. > > > > I tested on arm64 platform Juno-r2 and one of my laptop with x86 > > architecture with below steps; I don't test for Arm architecture so > > only pass compilation. > > > > - Enable kernel configuration: > > CONFIG_BPF_KPROBE_OVERRIDE > > CONFIG_BTRFS_FS > > CONFIG_BPF_EVENTS=y > > CONFIG_KPROBES=y > > CONFIG_KPROBE_EVENTS=y > > CONFIG_BPF_KPROBE_OVERRIDE=y > > > > - Build samples/bpf on with Debian rootFS: > > # cd $kernel > > # make headers_install > > # make samples/bpf/ LLC=llc-7 CLANG=clang-7 > > > > - Run the sample tracex7: > > # dd if=/dev/zero of=testfile.img bs=1M seek=1000 count=1 > > # DEVICE=$(losetup --show -f testfile.img) > > # mkfs.btrfs -f $DEVICE > > # ./tracex7 testfile.img > > [ 1975.211781] BTRFS error (device (efault)): open_ctree failed > > mount: /mnt/linux-kernel/linux-cs-dev/samples/bpf/tmpmnt: mount(2) system call failed: Cannot allocate memory. > > > > Changes from v1: > > * Consolidated the function definition into asm-generic header (Will); > > * Used APIs to access pt_regs elements (Will); > > * Fixed typos in the comments (Will). > > This looks good to me. > > Reviewed-by: Masami Hiramatsu > > Thank you! Thanks a lot for reviewing, Masami. Leo.