From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30B32C433FF for ; Tue, 13 Aug 2019 10:06:55 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEFEE20665 for ; Tue, 13 Aug 2019 10:06:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEFEE20665 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4677fh6d71zDqfZ for ; Tue, 13 Aug 2019 20:06:52 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=lorenzo.pieralisi@arm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4677bS4jBXzDqcK for ; Tue, 13 Aug 2019 20:04:03 +1000 (AEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A0511570; Tue, 13 Aug 2019 03:04:02 -0700 (PDT) Received: from red-moon (red-moon.cambridge.arm.com [10.1.197.39]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CCC683F774; Tue, 13 Aug 2019 03:03:59 -0700 (PDT) Date: Tue, 13 Aug 2019 11:04:09 +0100 From: Lorenzo Pieralisi To: Xiaowei Bao Subject: Re: [PATCHv5 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver. Message-ID: <20190813100409.GB10070@red-moon> References: <20190813062840.2733-1-xiaowei.bao@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190813062840.2733-1-xiaowei.bao@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, roy.zang@nxp.com, leonard.crestez@nxp.com, hayashi.kunihiko@socionext.com, andrew.smirnov@gmail.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, yue.wang@amlogic.com, kishon@ti.com, minghuan.Lian@nxp.com, dwmw@amazon.co.uk, jonnyc@amazon.com, bhelgaas@google.com, tpiepho@impinj.com, linuxppc-dev@lists.ozlabs.org, mingkai.hu@nxp.com, l.stach@pengutronix.de Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" git log --oneline --follow drivers/pci/controller/dwc/pci-layerscape.c Do you see any commit with a $SUBJECT ending with a period ? There is not. So remove it from yours too. On Tue, Aug 13, 2019 at 02:28:39PM +0800, Xiaowei Bao wrote: > The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 > is 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware, > so set the bar_fixed_64bit with 0x14. > > Signed-off-by: Xiaowei Bao > --- > v2: > - Replace value 0x14 with a macro. > v3: > - No change. > v4: > - send the patch again with '--to'. > v5: > - fix the commit message. > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > 1 file changed, 1 insertion(+) scripts/get_maintainer.pl -f drivers/pci/controller/dwc/pci-layerscape-ep.c Now, with the output you get justify all the people you send this email to. So, again, trim the CC list and it is the last time I tell you. Before sending patches on mailing lists use git --dry-run to check the emails you are sending. Thanks, Lorenzo > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > index be61d96..ca9aa45 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > @@ -44,6 +44,7 @@ static const struct pci_epc_features ls_pcie_epc_features = { > .linkup_notifier = false, > .msi_capable = true, > .msix_capable = false, > + .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4), > }; > > static const struct pci_epc_features* > -- > 2.9.5 >