From: Michal Suchanek <msuchanek@suse.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: Yangtao Li <tiny.windzz@gmail.com>,
Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Hari Bathini <hbathini@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Michal Suchanek <msuchanek@suse.de>
Subject: [PATCH rebased] powerpc/fadump: when fadump is supported register the fadump sysfs files.
Date: Tue, 20 Aug 2019 20:12:11 +0200 [thread overview]
Message-ID: <20190820181211.14694-1-msuchanek@suse.de> (raw)
Currently it is not possible to distinguish the case when fadump is
supported by firmware and disabled in kernel and completely unsupported
using the kernel sysfs interface. User can investigate the devicetree
but it is more reasonable to provide sysfs files in case we get some
fadumpv2 in the future.
With this patch sysfs files are available whenever fadump is supported
by firmware.
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
Rebase on top of http://patchwork.ozlabs.org/patch/1150160/
[v5,31/31] powernv/fadump: support holes in kernel boot memory area
---
arch/powerpc/kernel/fadump.c | 33 ++++++++++++++++++---------------
1 file changed, 18 insertions(+), 15 deletions(-)
diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
index 4b1bb3c55cf9..7ad424729e9c 100644
--- a/arch/powerpc/kernel/fadump.c
+++ b/arch/powerpc/kernel/fadump.c
@@ -1319,13 +1319,9 @@ static void fadump_init_files(void)
*/
int __init setup_fadump(void)
{
- if (!fw_dump.fadump_enabled)
- return 0;
-
- if (!fw_dump.fadump_supported) {
+ if (!fw_dump.fadump_supported && fw_dump.fadump_enabled) {
printk(KERN_ERR "Firmware-assisted dump is not supported on"
" this hardware\n");
- return 0;
}
fadump_show_config();
@@ -1333,19 +1329,26 @@ int __init setup_fadump(void)
* If dump data is available then see if it is valid and prepare for
* saving it to the disk.
*/
- if (fw_dump.dump_active) {
+ if (fw_dump.fadump_enabled) {
+ if (fw_dump.dump_active) {
+ /*
+ * if dump process fails then invalidate the
+ * registration and release memory before proceeding
+ * for re-registration.
+ */
+ if (fw_dump.ops->fadump_process(&fw_dump) < 0)
+ fadump_invalidate_release_mem();
+ }
/*
- * if dump process fails then invalidate the registration
- * and release memory before proceeding for re-registration.
+ * Initialize the kernel dump memory structure for FAD
+ * registration.
*/
- if (fw_dump.ops->fadump_process(&fw_dump) < 0)
- fadump_invalidate_release_mem();
- }
- /* Initialize the kernel dump memory structure for FAD registration. */
- else if (fw_dump.reserve_dump_area_size)
- fw_dump.ops->fadump_init_mem_struct(&fw_dump);
+ else if (fw_dump.reserve_dump_area_size)
+ fw_dump.ops->fadump_init_mem_struct(&fw_dump);
- fadump_init_files();
+ }
+ if (fw_dump.fadump_supported)
+ fadump_init_files();
return 1;
}
--
2.22.0
next reply other threads:[~2019-08-20 18:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 18:12 Michal Suchanek [this message]
2019-08-27 12:27 ` [PATCH rebased] powerpc/fadump: when fadump is supported register the fadump sysfs files Hari Bathini
2019-08-28 17:07 ` Michal Suchánek
2019-08-29 5:20 ` Hari Bathini
2019-08-28 17:27 ` [PATCH v2] " Michal Suchanek
2019-08-29 5:28 ` Hari Bathini
2019-09-04 18:35 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820181211.14694-1-msuchanek@suse.de \
--to=msuchanek@suse.de \
--cc=hbathini@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).