From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED3F5C3A59F for ; Thu, 29 Aug 2019 12:48:13 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74F4F2339E for ; Thu, 29 Aug 2019 12:48:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74F4F2339E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46K2TQ4c2pzDrVx for ; Thu, 29 Aug 2019 22:48:10 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=suse.de (client-ip=195.135.220.15; helo=mx1.suse.de; envelope-from=msuchanek@suse.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.de Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46K2F02H41zDqRX for ; Thu, 29 Aug 2019 22:37:24 +1000 (AEST) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id EE906AC67; Thu, 29 Aug 2019 12:37:20 +0000 (UTC) Date: Thu, 29 Aug 2019 14:37:16 +0200 From: Michal =?UTF-8?B?U3VjaMOhbmVr?= To: Arnd Bergmann Subject: Re: [PATCH v4 1/4] powerpc: make llseek 32bit-only. Message-ID: <20190829143716.6e41b10e@naga> In-Reply-To: References: <061a0de2042156669303f95526ec13476bf490c7.1567072270.git.msuchanek@suse.de> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Neuling , Andrew Donnellan , Nicolai Stange , David Hildenbrand , Greg Kroah-Hartman , Heiko Carstens , Linux Kernel Mailing List , Nicholas Piggin , David Howells , Hari Bathini , Paul Mackerras , Joel Stanley , Christian Brauner , Firoz Khan , Breno Leitao , Geert Uytterhoeven , Thomas Gleixner , linuxppc-dev , Allison Randal , "Eric W. Biederman" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 29 Aug 2019 14:19:46 +0200 Arnd Bergmann wrote: > On Thu, Aug 29, 2019 at 12:23 PM Michal Suchanek wrote: > > > > Fixes: aff850393200 ("powerpc: add system call table generation support") > > This patch needs a proper explanation. The Fixes tag doesn't seem right > here, since ppc64 has had llseek since the start in 2002 commit 3939e37587e7 > ("Add ppc64 support. This includes both pSeries (RS/6000) and iSeries > (AS/400)."). > > > diff --git a/arch/powerpc/kernel/syscalls/syscall.tbl b/arch/powerpc/kernel/syscalls/syscall.tbl > > index 010b9f445586..53e427606f6c 100644 > > --- a/arch/powerpc/kernel/syscalls/syscall.tbl > > +++ b/arch/powerpc/kernel/syscalls/syscall.tbl > > @@ -188,7 +188,7 @@ > > 137 common afs_syscall sys_ni_syscall > > 138 common setfsuid sys_setfsuid > > 139 common setfsgid sys_setfsgid > > -140 common _llseek sys_llseek > > +140 32 _llseek sys_llseek > > 141 common getdents sys_getdents compat_sys_getdents > > 142 common _newselect sys_select compat_sys_select > > 143 common flock sys_flock > > In particular, I don't see why you single out llseek here, but leave other > syscalls that are not needed on 64-bit machines such as pread64(). Because llseek is not built in fs/ when building 64bit only causing a link error. I initially posted patch to build it always but it was pointed out it is not needed, and the interface does not make sense on 64bit, and that platforms that don't have it on 64bit now don't want that useless code. Thanks Michal