From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92FD0C49ED9 for ; Thu, 12 Sep 2019 05:33:50 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E79220856 for ; Thu, 12 Sep 2019 05:33:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H7SNwAq/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E79220856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46TS9l6xYxzF451 for ; Thu, 12 Sep 2019 15:33:47 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::543; helo=mail-pg1-x543.google.com; envelope-from=oohall@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="H7SNwAq/"; dkim-atps=neutral Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46TS5T5vhCzF3Yt for ; Thu, 12 Sep 2019 15:30:03 +1000 (AEST) Received: by mail-pg1-x543.google.com with SMTP id c17so5045705pgg.4 for ; Wed, 11 Sep 2019 22:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yQD8TrOfS3maPpbFsY93lDWyVJH7XbSLS4gZhh7W9kE=; b=H7SNwAq/Q1NiucsnVEhSntpKXaJLAzjQS91knVgLLz14DXpyZVsZDyasD7h/DMoK+v sZmQhTaqlWV2sMHNv8vUEtZM3BeJ411TQ0022TmsDQOYjeQ/f7iemPc0pfuMHpGjlEHA zXvxzfy5WDYuTKdZ9o2jEL5Ptm7euulfdmv/IIujZlbtQUpE8F1zmu3Y4H1Tybiiicfw A7VRYuUFXEwjl7jln9RaspfjhdN6PMgBbpa1qFkDN+rA2G0ou36My6nEn/sIicYKqzP9 JAh81+vj8o7motTG+bA7SZejFs2I0V77Fn8+qxeg0rPMIb38T6w9ERGGAEBT7yc3QKVR aEew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yQD8TrOfS3maPpbFsY93lDWyVJH7XbSLS4gZhh7W9kE=; b=Z7+65aI0n0qfVIu38eHT+VflFEuPiqWiMmb/Ldauv4ervz3AQOtnNfoTXQNnzwlVJn 35urn4x0WaXxU0yNkGz+Y5vrClIRzmRkFYvolZdm//yXUR920DYwWEAisqH9w0gNJp3D eEjd2flaGE2gAjZ3WV2BGJdeUqdSsDnAXcf4HMu7pLCJWNIDdsQPP+WHM/ZFgMxYahRL BGguRC7qvzmDuHagAJqaiBE1MbNInNmPtM9u6qyIYh0pZAv7d3yrxhtJBcs3+nr0T7Ty MW/jEDZ1Cy1XMbW84pligOELNMLu/HTh2P2AhvfTxCJUSCYJPdEKzPQwtJV71nKxOV/f TNFg== X-Gm-Message-State: APjAAAUaC5umYzoKrPYdBrlMklSiWsngkCMRBEcVQKLNnKAteLwghxvx CQUG+t/pZ66B+i8sMOko/TcaTX5V X-Google-Smtp-Source: APXvYqyjkymkfhGk5UoP9E6M2Rf+kqzt2zf/SvuzXJUFMaPRNHJ6HbwpZBzUZMi2VoBAlDJfzmsn4g== X-Received: by 2002:aa7:9688:: with SMTP id f8mr45674972pfk.77.1568266201345; Wed, 11 Sep 2019 22:30:01 -0700 (PDT) Received: from wafer.ozlabs.ibm.com.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id n66sm35884386pfn.90.2019.09.11.22.29.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Sep 2019 22:30:01 -0700 (PDT) From: Oliver O'Halloran To: linuxppc-dev@lists.ozlabs.org Subject: [PATCH 2/3] powernv/pci: Allow any write trigger the diag dump Date: Thu, 12 Sep 2019 15:29:44 +1000 Message-Id: <20190912052945.12589-2-oohall@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190912052945.12589-1-oohall@gmail.com> References: <20190912052945.12589-1-oohall@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oliver O'Halloran Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Make the dump trigger off any input rather than just '1'. This allows you to write "echo 1> dump_diag_data" and it'll do what you want rather than erroring out pointlessly. Signed-off-by: Oliver O'Halloran --- arch/powerpc/platforms/powernv/pci-ioda.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c index b24339b..f684d3a 100644 --- a/arch/powerpc/platforms/powernv/pci-ioda.c +++ b/arch/powerpc/platforms/powernv/pci-ioda.c @@ -3047,9 +3047,6 @@ static int pnv_pci_diag_data_set(void *data, u64 val) struct pnv_phb *phb = data; s64 ret; - if (val != 1ULL) - return -EINVAL; - /* Retrieve the diag data from firmware */ ret = opal_pci_get_phb_diag_data2(phb->opal_id, phb->diag_data, phb->diag_data_size); -- 2.9.5