From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35107ECE587 for ; Tue, 1 Oct 2019 18:18:48 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EEE52168B for ; Tue, 1 Oct 2019 18:18:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="XJsPkZ+j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EEE52168B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46jSFc5w3nzDqVN for ; Wed, 2 Oct 2019 04:18:44 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46jSCR4cGXzDqSf for ; Wed, 2 Oct 2019 04:16:51 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="XJsPkZ+j"; dkim-atps=neutral Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) by bilbo.ozlabs.org (Postfix) with ESMTP id 46jSCR1yhkz8tCq for ; Wed, 2 Oct 2019 04:16:51 +1000 (AEST) Received: by ozlabs.org (Postfix) id 46jSCR1cSPz9sPJ; Wed, 2 Oct 2019 04:16:51 +1000 (AEST) Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linuxfoundation.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="XJsPkZ+j"; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46jSCQ3GwKz9sN1; Wed, 2 Oct 2019 04:16:50 +1000 (AEST) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3CCA420815; Tue, 1 Oct 2019 18:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569953807; bh=URWEvpqEPZZw2zcAevFFbA8yQME/4wiIjpDJ7FcpsdE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XJsPkZ+jZl2+AUEnqAq6lSM/s8DyCVx6LUJMP+/Np0MkQAeL71jL5gsa5Mn7Q86a2 uTfBx8fqyWt1NnSsbz8Kwv6F8m2+9WsLXM83IUJBBRUrhImavvhgzh4dYXvOi1oB7U MuE4gbxlIECr316C0KJCDmkRDv5t+hqeuqfKZ1kU= Date: Tue, 1 Oct 2019 20:16:01 +0200 From: Greg Kroah-Hartman To: Nayna Subject: Re: [PATCH] sysfs: add BIN_ATTR_WO() macro Message-ID: <20191001181601.GA3705194@kroah.com> References: <1566825818-9731-1-git-send-email-nayna@linux.ibm.com> <1566825818-9731-3-git-send-email-nayna@linux.ibm.com> <20190826140131.GA15270@kroah.com> <20190826150153.GD18418@kroah.com> <7546990b-8060-9451-129a-19aaa856d2e1@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7546990b-8060-9451-129a-19aaa856d2e1@linux.vnet.ibm.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-efi@vger.kernel.org, Ard Biesheuvel , Eric Ricther , Nayna Jain , linux-kernel@vger.kernel.org, Mimi Zohar , Claudio Carvalho , Matthew Garret , linuxppc-dev@ozlabs.org, Paul Mackerras , Jeremy Kerr , Elaine Palmer , Oliver O'Halloran , linux-integrity@vger.kernel.org, George Wilson Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Oct 01, 2019 at 02:08:53PM -0400, Nayna wrote: > Hi Greg, > > > On 08/26/2019 11:01 AM, Greg Kroah-Hartman wrote: > > This variant was missing from sysfs.h, I guess no one noticed it before. > > > > Turns out the powerpc secure variable code can use it, so add it to the > > tree for it, and potentially others to take advantage of, instead of > > open-coding it. > > > > Reported-by: Nayna Jain > > Signed-off-by: Greg Kroah-Hartman > > --- > > > > I'll queue this up to my tree for 5.4-rc1, but if you want to take this > > in your tree earlier, feel free to do so. > > > > include/linux/sysfs.h | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h > > index 965236795750..5420817ed317 100644 > > --- a/include/linux/sysfs.h > > +++ b/include/linux/sysfs.h > > @@ -196,6 +196,12 @@ struct bin_attribute { > > .size = _size, \ > > } > > +#define __BIN_ATTR_WO(_name) { \ > > + .attr = { .name = __stringify(_name), .mode = 0200 }, \ > > + .store = _name##_store, \ > > + .size = _size, \ > > +} > > + > > #define __BIN_ATTR_RW(_name, _size) \ > > __BIN_ATTR(_name, 0644, _name##_read, _name##_write, _size) > > @@ -208,6 +214,9 @@ struct bin_attribute bin_attr_##_name = __BIN_ATTR(_name, _mode, _read, \ > > #define BIN_ATTR_RO(_name, _size) \ > > struct bin_attribute bin_attr_##_name = __BIN_ATTR_RO(_name, _size) > > +#define BIN_ATTR_WO(_name, _size) \ > > +struct bin_attribute bin_attr_##_name = __BIN_ATTR_WO(_name, _size) > > + > > #define BIN_ATTR_RW(_name, _size) \ > > struct bin_attribute bin_attr_##_name = __BIN_ATTR_RW(_name, _size) > > I am sorry. I didn't notice it via inspection but there is a bug in this > macro. When I actually try using it, compilation fails. Here's a likely > patch: > > diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h > index 5420817ed317..fa7ee503fb76 100644 > --- a/include/linux/sysfs.h > +++ b/include/linux/sysfs.h > @@ -196,9 +196,9 @@ struct bin_attribute { > .size = _size, \ > } > -#define __BIN_ATTR_WO(_name) { \ > +#define __BIN_ATTR_WO(_name, _size) { \ > .attr = { .name = __stringify(_name), .mode = 0200 }, \ > - .store = _name##_store, \ > + .write = _name##_write, \ > .size = _size, \ > } > Heh, good catch. Can you send a real patch for this that I can apply to give you the proper credit for finding and fixing this? thanks, greg k-h