From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B600ECE58C for ; Mon, 7 Oct 2019 14:03:13 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29D6D206C2 for ; Mon, 7 Oct 2019 14:03:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="1dC/oO7K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29D6D206C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46n2Hy3sYwzDqMr for ; Tue, 8 Oct 2019 01:03:10 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=shutemov.name (client-ip=2a00:1450:4864:20::544; helo=mail-ed1-x544.google.com; envelope-from=kirill@shutemov.name; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="1dC/oO7K"; dkim-atps=neutral Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46n2FY34JkzDqKD for ; Tue, 8 Oct 2019 01:01:04 +1100 (AEDT) Received: by mail-ed1-x544.google.com with SMTP id a15so12548438edt.6 for ; Mon, 07 Oct 2019 07:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rKL1w3iXknpln9Ux2lFi8nURmFThC0ACAB38j7xMJOw=; b=1dC/oO7KYUhQk3Cp+gPvQQFfNUhXo7xBP7fOg6lJXEJoNi4xqoFx/+Z/eteEJO7TfS beXRbX34FM5TGrxRC9UtlPyVu0dSHSWxoZtuR+BBMIz3ysIcWEMjUC0trYfvncn0/S1K bedaHLGes2jPFyGX3hZIeFJI6nEWOI1RFwcmLQ/j5X/1FPSdYeaocVmbj1FV4QMO0Ct3 gzIXMAqry05u2l85X3+0Gg6QDGEktesNKTlT1AuPCVLEt0ZvIsj2v9MyWo4Idq82kDyc ct/NK1YDtzPjx53EMdfO2f0gZjT1d4J5zb0WVTYkaD/x8lXnVmFKIb86ehHVrjIfm46m og+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rKL1w3iXknpln9Ux2lFi8nURmFThC0ACAB38j7xMJOw=; b=qz7Cd4r751UHpXnpUKH6P0kMZCN/RZV1XJ5x3DUfW97zElI3cDpHJTxJG07wOO9kDX HxbHVHzdkeIDOV1EVxjWMtHd402Hfp3tuyNJFKsMX2Ijig/b+ez43R3FXXMrDh+WzvNa IACBML47pI25NGAJWP3FsfdF8IVQtDjedaamSsnpoZvY3bTc4hsM+pCMNjwZWnnZbACX jRXSw9gxnoSFJEACMikBDkw/NPNwh3HZpGM/iCqBUrNCQU2R7P3G5PjoDcBzg8s+HYSU Vghd9hQc+/pbQUfB1Lc09jdj9Aj8mwcpyuAEHtfXHuO7DQua+j0+Uoj8knfLL9ztHW7Z xNRA== X-Gm-Message-State: APjAAAXyM54EaBW2QTtm8hldlD6EYjvTeVuDBoBZeHjsKLkrCRQnTWVA Ylgle1Y/r4C5m2wHWihYvlpbTg== X-Google-Smtp-Source: APXvYqxuYtPtzk9H5R4kXUotDVtZLwRxmHkom44kwHAzQPnIVU9Dw79/zIRyaunZCbGIUeO/BsAK1g== X-Received: by 2002:a17:906:4d08:: with SMTP id r8mr10168700eju.283.1570456860258; Mon, 07 Oct 2019 07:01:00 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id r18sm3382249edl.6.2019.10.07.07.00.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Oct 2019 07:00:59 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id BDCFF100287; Mon, 7 Oct 2019 17:00:58 +0300 (+03) Date: Mon, 7 Oct 2019 17:00:58 +0300 From: "Kirill A. Shutemov" To: Ingo Molnar Subject: Re: [PATCH V4 2/2] mm/pgtable/debug: Add test validating architecture page table helpers Message-ID: <20191007140058.um5g44rvxyzyiref@box> References: <1570427124-21887-1-git-send-email-anshuman.khandual@arm.com> <1570427124-21887-3-git-send-email-anshuman.khandual@arm.com> <20191007130617.GB56546@gmail.com> <20191007132607.4q537nauwfn5thol@box> <20191007135158.GA36360@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191007135158.GA36360@gmail.com> User-Agent: NeoMutt/20180716 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Tetsuo Handa , Heiko Carstens , Michal Hocko , linux-mm@kvack.org, Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Jason Gunthorpe , Gerald Schaefer , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kees Cook , Anshuman Khandual , Masahiro Yamada , Mark Brown , Dan Williams , Vlastimil Babka , Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , Dave Hansen , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Oct 07, 2019 at 03:51:58PM +0200, Ingo Molnar wrote: > > * Kirill A. Shutemov wrote: > > > On Mon, Oct 07, 2019 at 03:06:17PM +0200, Ingo Molnar wrote: > > > > > > * Anshuman Khandual wrote: > > > > > > > This adds a test module which will validate architecture page table helpers > > > > and accessors regarding compliance with generic MM semantics expectations. > > > > This will help various architectures in validating changes to the existing > > > > page table helpers or addition of new ones. > > > > > > > > Test page table and memory pages creating it's entries at various level are > > > > all allocated from system memory with required alignments. If memory pages > > > > with required size and alignment could not be allocated, then all depending > > > > individual tests are skipped. > > > > > > > diff --git a/arch/x86/include/asm/pgtable_64_types.h b/arch/x86/include/asm/pgtable_64_types.h > > > > index 52e5f5f2240d..b882792a3999 100644 > > > > --- a/arch/x86/include/asm/pgtable_64_types.h > > > > +++ b/arch/x86/include/asm/pgtable_64_types.h > > > > @@ -40,6 +40,8 @@ static inline bool pgtable_l5_enabled(void) > > > > #define pgtable_l5_enabled() 0 > > > > #endif /* CONFIG_X86_5LEVEL */ > > > > > > > > +#define mm_p4d_folded(mm) (!pgtable_l5_enabled()) > > > > + > > > > extern unsigned int pgdir_shift; > > > > extern unsigned int ptrs_per_p4d; > > > > > > Any deep reason this has to be a macro instead of proper C? > > > > It's a way to override the generic mm_p4d_folded(). It can be rewritten > > as inline function + define. Something like: > > > > #define mm_p4d_folded mm_p4d_folded > > static inline bool mm_p4d_folded(struct mm_struct *mm) > > { > > return !pgtable_l5_enabled(); > > } > > > > But I don't see much reason to be more verbose here than needed. > > C type checking? Documentation? Yeah, I know it's just a one-liner, but > the principle of the death by a thousand cuts applies here. Okay, if you think it worth it. Anshuman, could you fix it up for the next submission? > BTW., any reason this must be in the low level pgtable_64_types.h type > header, instead of one of the API level header files? I defined it next pgtable_l5_enabled(). What is more appropriate place to you? pgtable_64.h? Yeah, it makes sense. -- Kirill A. Shutemov