From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B95C5DF63 for ; Wed, 6 Nov 2019 15:13:11 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A6BE2178F for ; Wed, 6 Nov 2019 15:13:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A6BE2178F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 477VQr6QK5zDqCD for ; Thu, 7 Nov 2019 02:13:08 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=lorenzo.pieralisi@arm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 477VNF2mkXzF3dj for ; Thu, 7 Nov 2019 02:10:52 +1100 (AEDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8DA6F46A; Wed, 6 Nov 2019 07:01:35 -0800 (PST) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A418A3F71A; Wed, 6 Nov 2019 07:01:33 -0800 (PST) Date: Wed, 6 Nov 2019 15:01:28 +0000 From: Lorenzo Pieralisi To: "M.h. Lian" Subject: Re: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support Message-ID: <20191106150128.GA18689@e121166-lin.cambridge.arm.com> References: <20190902034319.14026-1-xiaowei.bao@nxp.com> <20190902034319.14026-3-xiaowei.bao@nxp.com> <20191105123233.GA26960@e121166-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , Roy Zang , Xiaowei Bao , "devicetree@vger.kernel.org" , "linux-pci@vger.kernel.org" , "Z.q. Hou" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Leo Li , "robh+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "bhelgaas@google.com" , "shawnguo@kernel.org" , Mingkai Hu Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Nov 06, 2019 at 03:46:17AM +0000, M.h. Lian wrote: > Hi Lorenzo, > > Sorry for the late reply. > > Acked-by: Minghuan Lian https://en.wikipedia.org/wiki/Posting_style#Top-posting Never top-post on kernel mailing lists. Thanks, Lorenzo > Thanks, > Minghuan > > > -----Original Message----- > > From: Xiaowei Bao > > Sent: Wednesday, November 6, 2019 11:36 AM > > To: Lorenzo Pieralisi > > Cc: robh+dt@kernel.org; mark.rutland@arm.com; shawnguo@kernel.org; > > Leo Li ; M.h. Lian ; Mingkai > > Hu ; Roy Zang ; linux- > > pci@vger.kernel.org; devicetree@vger.kernel.org; linux- > > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linuxppc- > > dev@lists.ozlabs.org; bhelgaas@google.com; Z.q. Hou > > > > Subject: RE: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support > > > > > > > > > -----Original Message----- > > > From: Lorenzo Pieralisi > > > Sent: 2019年11月5日 20:33 > > > To: Xiaowei Bao > > > Cc: robh+dt@kernel.org; mark.rutland@arm.com; shawnguo@kernel.org; > > Leo > > > Li ; M.h. Lian ; Mingkai > > Hu > > > ; Roy Zang ; > > > linux-pci@vger.kernel.org; devicetree@vger.kernel.org; > > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > > linuxppc-dev@lists.ozlabs.org; bhelgaas@google.com; Z.q. Hou > > > > > > Subject: Re: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support > > > > > > On Mon, Sep 02, 2019 at 11:43:19AM +0800, Xiaowei Bao wrote: > > > > Add support for the LS1028a PCIe controller. > > > > > > > > Signed-off-by: Xiaowei Bao > > > > Signed-off-by: Hou Zhiqiang > > > > --- > > > > v2: > > > > - No change. > > > > v3: > > > > - Reuse the ls2088 driver data structurt. > > > > v4: > > > > - No change. > > > > v5: > > > > - No change. > > > > v6: > > > > - No change. > > > > > > > > drivers/pci/controller/dwc/pci-layerscape.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > I have not seen any comment on any layerscape driver patches coming > > > from the maintainers as listed in the MAINTAINERS file (and CCed in this > > series). > > > > > > I request maintainers ACK on these patches and I expect them to start > > > reviewing your code if they want to be still considered maintainers > > > for this driver. > > > > > > The changes look OK minus Shawn's remark on compatible string that was > > > ignored. > > > > Hi Lorenzo, > > > > Thanks for your comments. > > > > In fact, the patches have reviewed in our internal mail list, after the review by > > Minghuan and Mingkai, I will send these patches to opensource, they will > > give the ACK when these patches seems is OK and no comments on this. > > > > Thanks > > Xiaowei > > > > > > > > Thanks, > > > Lorenzo > > > > > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c > > > > b/drivers/pci/controller/dwc/pci-layerscape.c > > > > index 3a5fa26..f24f79a 100644 > > > > --- a/drivers/pci/controller/dwc/pci-layerscape.c > > > > +++ b/drivers/pci/controller/dwc/pci-layerscape.c > > > > @@ -263,6 +263,7 @@ static const struct ls_pcie_drvdata > > > > ls2088_drvdata = { static const struct of_device_id ls_pcie_of_match[] = { > > > > { .compatible = "fsl,ls1012a-pcie", .data = &ls1046_drvdata }, > > > > { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, > > > > + { .compatible = "fsl,ls1028a-pcie", .data = &ls2088_drvdata }, > > > > { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, > > > > { .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata }, > > > > { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata }, > > > > -- > > > > 2.9.5 > > > >