From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAB5EC432C3 for ; Wed, 27 Nov 2019 08:35:22 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8601620684 for ; Wed, 27 Nov 2019 08:35:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cWqSTQcy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8601620684 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47NDc70DhnzDqjk for ; Wed, 27 Nov 2019 19:35:19 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=bombadil.srs.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=batv+230b1395c146a7dc824f+5939+infradead.org+hch@bombadil.srs.infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="cWqSTQcy"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47NDYs32SwzDqNm for ; Wed, 27 Nov 2019 19:33:21 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KAwS2evld93QnkccxirHuFvfYzrD0dfwnf1KEtGZmHg=; b=cWqSTQcy6hrQ85bxKY+KLCGfa bKJndEereM4HSqQoVJq7zXZam3aRKu3ENJ0pmd057SKKB0PH8FSA9Ob2zTn3X2uiOtSEAMbl/xCfP ZhRGt128YaGoJHyySwP6GQqJ3o0l7x821PxJ1LPKMqWP3Gp4VrLI5kRRu2Am3x2mL/dW8QZk57Fe1 q8ochN+PsGWuXY9ZjoZa9RfcV6DJH6/PFhLTz9XwyC++ljuBZK2WCVTIDf7gkUFmVYAjV2pm4092K 5tjdAqAtqr+cqm2XNNryK2jISAq8PLL/TJ+wl0T0f2eTuK0NSH6L9fybeMmc17xbPmRq/SArXjLpC 39YOqD96g==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iZslD-0007NO-NO; Wed, 27 Nov 2019 08:33:19 +0000 Date: Wed, 27 Nov 2019 00:33:19 -0800 From: Christoph Hellwig To: Haren Myneni Subject: Re: [PATCH 04/14] powerpc/vas: Setup IRQ mapping and register port for each window Message-ID: <20191127083319.GC17097@infradead.org> References: <1574816731.13250.9.camel@hbabu-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1574816731.13250.9.camel@hbabu-laptop> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, mikey@neuling.org, herbert@gondor.apana.org.au, npiggin@gmail.com, sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" > +static irqreturn_t vas_irq_handler(int virq, void *data) > +{ > + struct vas_instance *vinst = data; > + > + pr_devel("VAS %d: virq %d\n", vinst->vas_id, virq); > + > + return IRQ_HANDLED; > +} An empty interrupt handler is rather pointless. It later grows code, but adding it without that is a bad idea. Please squash the patches into sesible chunks.