From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02509C43603 for ; Thu, 19 Dec 2019 12:14:15 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FAEA20716 for ; Thu, 19 Dec 2019 12:14:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0ixnxT3u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FAEA20716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47drQX1sBjzDqsm for ; Thu, 19 Dec 2019 23:14:12 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=will@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="0ixnxT3u"; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47drMH4JkBzDqmj for ; Thu, 19 Dec 2019 23:11:23 +1100 (AEDT) Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1BEFF20716; Thu, 19 Dec 2019 12:11:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576757481; bh=RE2T76IU/lncwRrDRAlG+ju/T9yNzhZZa+kkSWXB+hk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0ixnxT3uqPi6FVe/deKUePFfnKx9P1IGOKn1P09zsr5cJF5tc+Lb/RinNJ6zRexCz d4w/YFMVv6noAYAo12vcpw9/xsADKJmW1JkRrwXaOXPOxbKCpRgXB/UF6b9ftaH2wF dIhF3//DAkyn3jnXauqEMxnnraV8I9v9EaclRVHs= Date: Thu, 19 Dec 2019 12:11:16 +0000 From: Will Deacon To: Linus Torvalds Subject: Re: READ_ONCE() + STACKPROTECTOR_STRONG == :/ (was Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.5-2 tag (topic/kasan-bitops)) Message-ID: <20191219121115.GB32361@willie-the-truck> References: <20191212100756.GA11317@willie-the-truck> <20191212104610.GW2827@hirez.programming.kicks-ass.net> <20191212180634.GA19020@willie-the-truck> <20191212193401.GB19020@willie-the-truck> <20191217170719.GA869@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Arnd Bergmann , Peter Zijlstra , Linux Kernel Mailing List , Christian Borntraeger , Mark Rutland , linuxppc-dev , Daniel Axtens Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Dec 17, 2019 at 10:32:35AM -0800, Linus Torvalds wrote: > On Tue, Dec 17, 2019 at 10:04 AM Linus Torvalds > wrote: > > > > Let me think about it. > > How about we just get rid of the union entirely, and just use > 'unsigned long' or 'unsigned long long' depending on the size. > > Something like the attached patch - it still requires that it be an > arithmetic type, but now because of the final cast. > > But it might still be a cast to a volatile type, of course. Then the > result will be volatile, but at least now READ_ONCE() won't be taking > the address of a volatile variable on the stack - does that at least > fix some of the horrible code generation. Hmm? Sounds like it according to mpe, but I'll confirm too for arm64. > This is untested, because I obviously still have the cases of > structures (page table entries) being accessed once.. > > Linus > include/linux/compiler.h | 33 +++++++++++++++++---------------- > 1 file changed, 17 insertions(+), 16 deletions(-) > > diff --git a/include/linux/compiler.h b/include/linux/compiler.h > index 5e88e7e33abe..8b4282194f16 100644 > --- a/include/linux/compiler.h > +++ b/include/linux/compiler.h > @@ -179,18 +179,18 @@ void ftrace_likely_update(struct ftrace_likely_data *f, int val, > > #include > > -#define __READ_ONCE_SIZE \ > -({ \ > - switch (size) { \ > - case 1: *(__u8 *)res = *(volatile __u8 *)p; break; \ > - case 2: *(__u16 *)res = *(volatile __u16 *)p; break; \ > - case 4: *(__u32 *)res = *(volatile __u32 *)p; break; \ > - case 8: *(__u64 *)res = *(volatile __u64 *)p; break; \ > - default: \ > - barrier(); \ > - __builtin_memcpy((void *)res, (const void *)p, size); \ > - barrier(); \ > - } \ > +/* "unsigned long" or "unsigned long long" - make it fit in a register if possible */ > +#define __READ_ONCE_TYPE(size) \ > + __typeof__(__builtin_choose_expr(size > sizeof(0UL), 0ULL, 0UL)) Ha, I wondered when '__builtin_choose_expr()' would make an appearance in this thread! Nice trick. I'll try integrating this with what I have and see what I run into next. Back down the rabbit hole... Will