From: Gautham R Shenoy <ego@linux.vnet.ibm.com>
To: Nathan Lynch <nathanl@linux.ibm.com>
Cc: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>,
Tyrel Datwyler <tyreld@linux.ibm.com>,
linux-kernel@vger.kernel.org,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/3] powerpc/sysfs: Show idle_purr and idle_spurr for every CPU
Date: Mon, 3 Feb 2020 10:17:35 +0530 [thread overview]
Message-ID: <20200203044735.GB13468@in.ibm.com> (raw)
In-Reply-To: <87pnh3u3ts.fsf@linux.ibm.com>
Hello Nathan,
On Wed, Dec 04, 2019 at 04:24:31PM -0600, Nathan Lynch wrote:
> "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> writes:
> > @@ -1067,6 +1097,8 @@ static int __init topology_init(void)
> > register_cpu(c, cpu);
> >
> > device_create_file(&c->dev, &dev_attr_physical_id);
> > + if (firmware_has_feature(FW_FEATURE_SPLPAR))
> > + create_idle_purr_spurr_sysfs_entry(&c->dev);
>
> Architecturally speaking PURR/SPURR aren't strongly linked to the PAPR
> SPLPAR option, are they? I'm not sure it's right for these attributes to
> be absent if the platform does not support shared processor mode.
Doesn't FW_FEATURE_SPLPAR refer to all Pseries guests ? It is perhaps
incorrectly named, but from the other uses in the kernel, it seems to
indicate that we are running as a guest instead of on a bare-metal
system.
--
Thanks and Regards
gautham.
next prev parent reply other threads:[~2020-02-03 4:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 12:01 [PATCH 0/3] pseries: Track and expose idle PURR and SPURR ticks Gautham R. Shenoy
2019-11-27 12:01 ` [PATCH 1/3] powerpc/pseries: Account for SPURR ticks on idle CPUs Gautham R. Shenoy
2019-12-03 13:39 ` Kamalesh Babulal
2019-12-04 22:24 ` Nathan Lynch
2020-02-03 4:45 ` Gautham R Shenoy
2019-11-27 12:01 ` [PATCH 2/3] powerpc/sysfs: Show idle_purr and idle_spurr for every CPU Gautham R. Shenoy
2019-12-03 13:37 ` Kamalesh Babulal
2019-12-04 12:37 ` Gautham R Shenoy
2019-12-03 21:02 ` kbuild test robot
2019-12-04 22:24 ` Nathan Lynch
2020-02-03 4:47 ` Gautham R Shenoy [this message]
2019-12-05 16:53 ` Naveen N. Rao
2020-02-03 4:50 ` Gautham R Shenoy
2020-02-04 7:52 ` Naveen N. Rao
2020-02-05 4:19 ` Gautham R Shenoy
2020-02-05 6:58 ` Naveen N. Rao
2020-02-05 7:08 ` Christophe Leroy
2020-02-05 8:07 ` Naveen N. Rao
2019-11-27 12:01 ` [PATCH 3/3] Documentation: Document sysfs interfaces purr, spurr, idle_purr, idle_spurr Gautham R. Shenoy
2019-12-04 22:25 ` Nathan Lynch
2019-12-04 22:24 ` [PATCH 0/3] pseries: Track and expose idle PURR and SPURR ticks Nathan Lynch
2019-12-05 15:03 ` Kamalesh Babulal
2019-12-05 16:16 ` Nathan Lynch
2019-12-05 17:25 ` Naveen N. Rao
2019-12-06 9:14 ` Naveen N. Rao
2020-02-04 9:12 ` Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203044735.GB13468@in.ibm.com \
--to=ego@linux.vnet.ibm.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nathanl@linux.ibm.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).