linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 6/7] powerpc/mm: implement set_memory_attr()
Date: Tue, 11 Feb 2020 15:25:47 +0800	[thread overview]
Message-ID: <202002111548.5KSPjAsB%lkp@intel.com> (raw)
In-Reply-To: <4a78ee8a7b954de0cfd44bd72b1b39c6fe34dc45.1580713729.git.christophe.leroy@c-s.fr>

[-- Attachment #1: Type: text/plain, Size: 3239 bytes --]

Hi Christophe,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.6-rc1 next-20200211]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Christophe-Leroy/powerpc-mm-Implement-set_memory-routines/20200204-030618
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-skiroot_defconfig (attached as .config)
compiler: powerpc64le-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/powerpc/include/asm/page.h:304:0,
                    from arch/powerpc/include/asm/mmu.h:132,
                    from arch/powerpc/include/asm/lppaca.h:47,
                    from arch/powerpc/include/asm/paca.h:17,
                    from arch/powerpc/include/asm/current.h:13,
                    from include/linux/thread_info.h:21,
                    from include/asm-generic/preempt.h:5,
                    from ./arch/powerpc/include/generated/asm/preempt.h:1,
                    from include/linux/preempt.h:78,
                    from include/linux/spinlock.h:51,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:6,
                    from include/linux/mm.h:10,
                    from arch/powerpc/mm/pageattr.c:9:
   arch/powerpc/mm/pageattr.c: In function 'set_page_attr':
>> arch/powerpc/mm/pageattr.c:85:27: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
     pgprot_t prot = __pgprot((int)data);
                              ^
   arch/powerpc/include/asm/pgtable-be-types.h:69:36: note: in definition of macro '__pgprot'
    #define __pgprot(x) ((pgprot_t) { (x) })
                                       ^
   cc1: all warnings being treated as errors

vim +85 arch/powerpc/mm/pageattr.c

    75	
    76	/*
    77	 * Set the attributes of a page:
    78	 *
    79	 * This function is used by PPC32 at the end of init to set final kernel memory
    80	 * protection. It includes changing the maping of the page it is executing from
    81	 * and data pages it is using.
    82	 */
    83	static int set_page_attr(pte_t *ptep, unsigned long addr, void *data)
    84	{
  > 85		pgprot_t prot = __pgprot((int)data);
    86	
    87		spin_lock(&init_mm.page_table_lock);
    88	
    89		set_pte_at(&init_mm, addr, ptep, pte_modify(*ptep, prot));
    90		flush_tlb_kernel_range(addr, addr + PAGE_SIZE);
    91	
    92		spin_unlock(&init_mm.page_table_lock);
    93	
    94		return 0;
    95	}
    96	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 20746 bytes --]

  reply	other threads:[~2020-02-11  7:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03  7:11 [PATCH v3 1/7] powerpc/mm: Implement set_memory() routines Christophe Leroy
2020-02-03  7:11 ` [PATCH v3 2/7] powerpc/kprobes: Mark newly allocated probes as RO Christophe Leroy
2020-02-03  7:11 ` [PATCH v3 3/7] powerpc/mm/ptdump: debugfs handler for W+X checks at runtime Christophe Leroy
2020-02-03  7:11 ` [PATCH v3 4/7] powerpc: Set ARCH_HAS_STRICT_MODULE_RWX Christophe Leroy
2020-02-03  7:12 ` [PATCH v3 5/7] powerpc/configs: Enable STRICT_MODULE_RWX in skiroot_defconfig Christophe Leroy
2020-02-03  7:12 ` [PATCH v3 6/7] powerpc/mm: implement set_memory_attr() Christophe Leroy
2020-02-11  7:25   ` kbuild test robot [this message]
2020-02-03  7:12 ` [PATCH v3 7/7] powerpc/32: use set_memory_attr() Christophe Leroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202002111548.5KSPjAsB%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=christophe.leroy@c-s.fr \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).