* [PATCH] powerpc: fix emulate_step std test
@ 2020-02-26 5:53 Nicholas Piggin
2020-02-27 7:04 ` Ravi Bangoria
2020-03-17 13:14 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Nicholas Piggin @ 2020-02-26 5:53 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Nicholas Piggin
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
arch/powerpc/lib/test_emulate_step.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/lib/test_emulate_step.c b/arch/powerpc/lib/test_emulate_step.c
index 42347067739c..00d70253cb5b 100644
--- a/arch/powerpc/lib/test_emulate_step.c
+++ b/arch/powerpc/lib/test_emulate_step.c
@@ -160,7 +160,7 @@ static void __init test_std(void)
/* std r5, 0(r3) */
stepped = emulate_step(®s, TEST_STD(5, 3, 0));
- if (stepped == 1 || regs.gpr[5] == a)
+ if (stepped == 1 && regs.gpr[5] == a)
show_result("std", "PASS");
else
show_result("std", "FAIL");
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc: fix emulate_step std test
2020-02-26 5:53 [PATCH] powerpc: fix emulate_step std test Nicholas Piggin
@ 2020-02-27 7:04 ` Ravi Bangoria
2020-03-17 13:14 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Ravi Bangoria @ 2020-02-27 7:04 UTC (permalink / raw)
To: Nicholas Piggin; +Cc: Ravi Bangoria, linuxppc-dev
On 2/26/20 11:23 AM, Nicholas Piggin wrote:
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> ---
> arch/powerpc/lib/test_emulate_step.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/lib/test_emulate_step.c b/arch/powerpc/lib/test_emulate_step.c
> index 42347067739c..00d70253cb5b 100644
> --- a/arch/powerpc/lib/test_emulate_step.c
> +++ b/arch/powerpc/lib/test_emulate_step.c
> @@ -160,7 +160,7 @@ static void __init test_std(void)
>
> /* std r5, 0(r3) */
> stepped = emulate_step(®s, TEST_STD(5, 3, 0));
> - if (stepped == 1 || regs.gpr[5] == a)
> + if (stepped == 1 && regs.gpr[5] == a)
> show_result("std", "PASS");
> else
> show_result("std", "FAIL");
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc: fix emulate_step std test
2020-02-26 5:53 [PATCH] powerpc: fix emulate_step std test Nicholas Piggin
2020-02-27 7:04 ` Ravi Bangoria
@ 2020-03-17 13:14 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2020-03-17 13:14 UTC (permalink / raw)
To: Nicholas Piggin, linuxppc-dev; +Cc: Nicholas Piggin
On Wed, 2020-02-26 at 05:53:02 UTC, Nicholas Piggin wrote:
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/59ed2adf393109c56d383e568f2e57bb5ad6d901
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-17 13:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-26 5:53 [PATCH] powerpc: fix emulate_step std test Nicholas Piggin
2020-02-27 7:04 ` Ravi Bangoria
2020-03-17 13:14 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).