From: kbuild test robot <lkp@intel.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: mikey@neuling.org, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 10/13] powerpc/ptrace: split out ADV_DEBUG_REGS related functions.
Date: Thu, 27 Feb 2020 03:11:58 +0800 [thread overview]
Message-ID: <202002270331.XCbJBQSD%lkp@intel.com> (raw)
In-Reply-To: <06a9634b5602ef7121fdae1385c74e090b706e17.1582717645.git.christophe.leroy@c-s.fr>
[-- Attachment #1: Type: text/plain, Size: 4234 bytes --]
Hi Christophe,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.6-rc3 next-20200226]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Christophe-Leroy/Reduce-ifdef-mess-in-ptrace/20200227-011143
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Note: the linux-review/Christophe-Leroy/Reduce-ifdef-mess-in-ptrace/20200227-011143 HEAD 14a582f53275332199397e25fe49bd2597d4cb19 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
arch/powerpc/kernel/ptrace/ptrace.c: In function 'ptrace_triggered':
>> arch/powerpc/kernel/ptrace/ptrace.c:46:2: error: implicit declaration of function 'modify_user_hw_breakpoint'; did you mean '__set_breakpoint'? [-Werror=implicit-function-declaration]
modify_user_hw_breakpoint(bp, &attr);
^~~~~~~~~~~~~~~~~~~~~~~~~
__set_breakpoint
cc1: all warnings being treated as errors
vim +46 arch/powerpc/kernel/ptrace/ptrace.c
57d28fcb6dde29 arch/powerpc/kernel/ptrace/ptrace.c Christophe Leroy 2020-02-26 31
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 32 #ifdef CONFIG_HAVE_HW_BREAKPOINT
a8b0ca17b80e92 arch/powerpc/kernel/ptrace.c Peter Zijlstra 2011-06-27 33 void ptrace_triggered(struct perf_event *bp,
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 34 struct perf_sample_data *data, struct pt_regs *regs)
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 35 {
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 36 struct perf_event_attr attr;
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 37
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 38 /*
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 39 * Disable the breakpoint request here since ptrace has defined a
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 40 * one-shot behaviour for breakpoint exceptions in PPC64.
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 41 * The SIGTRAP signal is generated automatically for us in do_dabr().
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 42 * We don't have to do anything about that here
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 43 */
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 44 attr = bp->attr;
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 45 attr.disabled = true;
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 @46 modify_user_hw_breakpoint(bp, &attr);
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 47 }
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 48 #endif /* CONFIG_HAVE_HW_BREAKPOINT */
5aae8a53708025 arch/powerpc/kernel/ptrace.c K.Prasad 2010-06-15 49
:::::: The code at line 46 was first introduced by commit
:::::: 5aae8a53708025d4e718f0d2e7c2f766779ddc71 powerpc, hw_breakpoints: Implement hw_breakpoints for 64-bit server processors
:::::: TO: K.Prasad <prasad@linux.vnet.ibm.com>
:::::: CC: Paul Mackerras <paulus@samba.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25741 bytes --]
next prev parent reply other threads:[~2020-02-26 19:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 11:53 [PATCH v3 00/13] Reduce ifdef mess in ptrace Christophe Leroy
2020-02-26 11:53 ` [PATCH v3 01/13] powerpc: move ptrace into a subdirectory Christophe Leroy
2020-02-26 11:53 ` [PATCH v3 02/13] powerpc/ptrace: remove unused header includes Christophe Leroy
2020-02-26 11:53 ` [PATCH v3 03/13] powerpc/ptrace: drop unnecessary #ifdefs CONFIG_PPC64 Christophe Leroy
2020-02-26 11:53 ` [PATCH v3 04/13] powerpc/ptrace: drop PARAMETER_SAVE_AREA_OFFSET Christophe Leroy
2020-02-26 11:53 ` [PATCH v3 05/13] powerpc/ptrace: split out VSX related functions Christophe Leroy
2020-02-26 11:53 ` [PATCH v3 06/13] powerpc/ptrace: split out ALTIVEC " Christophe Leroy
2020-02-26 11:53 ` [PATCH v3 07/13] powerpc/ptrace: split out SPE " Christophe Leroy
2020-02-26 11:53 ` [PATCH v3 08/13] powerpc/ptrace: split out TRANSACTIONAL_MEM " Christophe Leroy
2020-02-26 11:53 ` [PATCH v3 09/13] powerpc/ptrace: move register viewing functions out of ptrace.c Christophe Leroy
2020-02-26 11:54 ` [PATCH v3 10/13] powerpc/ptrace: split out ADV_DEBUG_REGS related functions Christophe Leroy
2020-02-26 19:11 ` kbuild test robot [this message]
2020-02-26 11:54 ` [PATCH v3 11/13] powerpc/ptrace: create ptrace_get_debugreg() Christophe Leroy
2020-02-26 11:54 ` [PATCH v3 12/13] powerpc/ptrace: create ppc_gethwdinfo() Christophe Leroy
2020-02-26 11:54 ` [PATCH v3 13/13] powerpc/ptrace: move ptrace_triggered() into hw_breakpoint.c Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202002270331.XCbJBQSD%lkp@intel.com \
--to=lkp@intel.com \
--cc=christophe.leroy@c-s.fr \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).