linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next 00/23] Clean driver, module and FW versions
@ 2020-03-01 14:44 Leon Romanovsky
  2020-03-01 14:44 ` [PATCH net-next 20/23] net/freescale: Clean drivers from static versions Leon Romanovsky
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Leon Romanovsky @ 2020-03-01 14:44 UTC (permalink / raw)
  To: David S . Miller, Jakub Kicinski
  Cc: Ajit Khaparde, Madalin Bucur, Denis Kirjanov, Prashant Sreedharan,
	Govindarajulu Varadarajan, Somnath Kotur, Vishal Kulkarni,
	GR-everest-linux-l2, Casey Leedom, Doug Berger,
	bcm-kernel-feedback-list, Linus Walleij, Sunil Goutham,
	Parvi Kaustubhi, Ariel Elior, Hans Ulli Kroll, Satanand Burla,
	Felix Manlunas, Leon Romanovsky, Claudiu Manoil, Florian Fainelli,
	Sathya Perla, Michael Chan, linux-arm-kernel, Raghu Vatsavayi,
	GR-Linux-NIC-Dev, Fugang Duan, Sriharsha Basavapatna,
	linux-parisc, Siva Reddy Kallam, Rasesh Mody, netdev,
	linux-kernel, Li Yang, Hartley Sweeten, Robert Richter,
	Derek Chickles, linuxppc-dev, Sudarsana Kalluru,
	Christian Benvenuti

From: Leon Romanovsky <leonro@mellanox.com>

Hi,

This is second batch of the series which removes various static versions
in favour of globaly defined Linux kernel version.

The first part with better cover letter can be found here
https://lore.kernel.org/lkml/20200224085311.460338-1-leon@kernel.org

The code is based on
68e2c37690b0 ("Merge branch 'hsr-several-code-cleanup-for-hsr-module'")

and WIP branch is
https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/log/?h=ethtool

Thanks

Leon Romanovsky (23):
  net/broadcom: Clean broadcom code from driver versions
  net/broadcom: Don't set N/A FW if it is not available
  net/brocade: Delete driver version
  net/liquidio: Delete driver version assignment
  net/liquidio: Delete non-working LIQUIDIO_PACKAGE check
  net/cavium: Clean driver versions
  net/cavium: Delete N/A assignments for ethtool
  net/chelsio: Delete drive and  module versions
  net/chelsio: Don't set N/A for not available FW
  net/cirrus: Delete driver version
  net/cisco: Delete driver and module versions
  net/cortina: Delete driver version from ethtool output
  net/davicom: Delete ethtool version assignment
  net/dec: Delete driver versions
  net/dlink: Remove driver version and release date
  net/dnet: Delete static version from the driver
  net/emulex: Delete driver version
  net/faraday: Delete driver version from the drivers
  net/fealnx: Delete driver version
  net/freescale: Clean drivers from static versions
  net/freescale: Don't set zero if FW not-available in dpaa
  net/freescale: Don't set zero if FW not-available in ucc_geth
  net/freescale: Don't set zero if FW iand bus not-available in gianfar

 drivers/net/ethernet/broadcom/b44.c           |  5 ----
 drivers/net/ethernet/broadcom/bcm63xx_enet.c  | 10 ++-----
 drivers/net/ethernet/broadcom/bcmsysport.c    |  1 -
 drivers/net/ethernet/broadcom/bnx2.c          | 11 --------
 drivers/net/ethernet/broadcom/bnx2x/bnx2x.h   |  8 +++++-
 .../ethernet/broadcom/bnx2x/bnx2x_ethtool.c   |  7 -----
 .../net/ethernet/broadcom/bnx2x/bnx2x_main.c  |  7 -----
 drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  8 ------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h     |  4 ++-
 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c |  1 -
 drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c |  1 -
 .../net/ethernet/broadcom/genet/bcmgenet.c    |  1 -
 drivers/net/ethernet/broadcom/tg3.c           | 11 +-------
 drivers/net/ethernet/brocade/bna/bnad.c       |  4 ---
 drivers/net/ethernet/brocade/bna/bnad.h       |  2 --
 .../net/ethernet/brocade/bna/bnad_ethtool.c   |  1 -
 .../ethernet/cavium/liquidio/lio_ethtool.c    |  2 --
 .../net/ethernet/cavium/liquidio/lio_main.c   |  8 ------
 .../ethernet/cavium/liquidio/lio_vf_main.c    |  5 ++--
 .../cavium/liquidio/liquidio_common.h         |  6 -----
 .../ethernet/cavium/liquidio/octeon_console.c | 10 ++-----
 .../net/ethernet/cavium/octeon/octeon_mgmt.c  |  6 -----
 .../ethernet/cavium/thunder/nicvf_ethtool.c   |  2 --
 drivers/net/ethernet/chelsio/cxgb/common.h    |  1 -
 drivers/net/ethernet/chelsio/cxgb/cxgb2.c     |  3 ---
 .../net/ethernet/chelsio/cxgb3/cxgb3_main.c   |  4 ---
 drivers/net/ethernet/chelsio/cxgb3/version.h  |  2 --
 drivers/net/ethernet/chelsio/cxgb4/cxgb4.h    |  3 +--
 .../ethernet/chelsio/cxgb4/cxgb4_ethtool.c    |  6 +----
 .../net/ethernet/chelsio/cxgb4/cxgb4_main.c   | 10 -------
 .../ethernet/chelsio/cxgb4vf/cxgb4vf_main.c   |  9 -------
 .../ethernet/chelsio/libcxgb/libcxgb_ppm.c    |  2 --
 drivers/net/ethernet/cirrus/ep93xx_eth.c      |  2 --
 drivers/net/ethernet/cisco/enic/enic.h        |  2 --
 .../net/ethernet/cisco/enic/enic_ethtool.c    |  1 -
 drivers/net/ethernet/cisco/enic/enic_main.c   |  3 ---
 drivers/net/ethernet/cortina/gemini.c         |  2 --
 drivers/net/ethernet/davicom/dm9000.c         |  2 --
 drivers/net/ethernet/dec/tulip/de2104x.c      | 15 -----------
 drivers/net/ethernet/dec/tulip/dmfe.c         | 14 ----------
 drivers/net/ethernet/dec/tulip/tulip_core.c   | 26 ++-----------------
 drivers/net/ethernet/dec/tulip/uli526x.c      | 13 ----------
 drivers/net/ethernet/dec/tulip/winbond-840.c  | 12 ---------
 drivers/net/ethernet/dlink/dl2k.c             |  9 -------
 drivers/net/ethernet/dlink/sundance.c         | 20 --------------
 drivers/net/ethernet/dnet.c                   |  1 -
 drivers/net/ethernet/dnet.h                   |  1 -
 drivers/net/ethernet/emulex/benet/be.h        |  1 -
 .../net/ethernet/emulex/benet/be_ethtool.c    |  1 -
 drivers/net/ethernet/emulex/benet/be_main.c   |  5 +---
 drivers/net/ethernet/faraday/ftgmac100.c      |  2 --
 drivers/net/ethernet/faraday/ftmac100.c       |  3 ---
 drivers/net/ethernet/fealnx.c                 | 20 --------------
 .../ethernet/freescale/dpaa/dpaa_ethtool.c    | 11 --------
 .../net/ethernet/freescale/enetc/enetc_pf.c   | 13 ----------
 .../net/ethernet/freescale/enetc/enetc_vf.c   | 12 ---------
 drivers/net/ethernet/freescale/fec_main.c     |  1 -
 .../ethernet/freescale/fs_enet/fs_enet-main.c |  2 --
 .../net/ethernet/freescale/fs_enet/fs_enet.h  |  2 --
 drivers/net/ethernet/freescale/gianfar.c      |  2 --
 drivers/net/ethernet/freescale/gianfar.h      |  1 -
 .../net/ethernet/freescale/gianfar_ethtool.c  |  4 ---
 drivers/net/ethernet/freescale/ucc_geth.c     |  1 -
 drivers/net/ethernet/freescale/ucc_geth.h     |  1 -
 .../net/ethernet/freescale/ucc_geth_ethtool.c |  2 --
 65 files changed, 22 insertions(+), 346 deletions(-)

--
2.24.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH net-next 20/23] net/freescale: Clean drivers from static versions
  2020-03-01 14:44 [PATCH net-next 00/23] Clean driver, module and FW versions Leon Romanovsky
@ 2020-03-01 14:44 ` Leon Romanovsky
  2020-03-01 14:44 ` [PATCH net-next 22/23] net/freescale: Don't set zero if FW not-available in ucc_geth Leon Romanovsky
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Leon Romanovsky @ 2020-03-01 14:44 UTC (permalink / raw)
  To: David S . Miller, Jakub Kicinski
  Cc: Fugang Duan, Madalin Bucur, netdev, Li Yang, Leon Romanovsky,
	Claudiu Manoil, linuxppc-dev

From: Leon Romanovsky <leonro@mellanox.com>

There is no need to set static versions because linux kernel is
released all together with same version applicable to the whole
code base.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
 drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c  |  2 --
 drivers/net/ethernet/freescale/enetc/enetc_pf.c     | 13 -------------
 drivers/net/ethernet/freescale/enetc/enetc_vf.c     | 12 ------------
 drivers/net/ethernet/freescale/fec_main.c           |  1 -
 .../net/ethernet/freescale/fs_enet/fs_enet-main.c   |  2 --
 drivers/net/ethernet/freescale/fs_enet/fs_enet.h    |  2 --
 drivers/net/ethernet/freescale/gianfar.c            |  2 --
 drivers/net/ethernet/freescale/gianfar.h            |  1 -
 drivers/net/ethernet/freescale/gianfar_ethtool.c    |  2 --
 drivers/net/ethernet/freescale/ucc_geth.c           |  1 -
 drivers/net/ethernet/freescale/ucc_geth.h           |  1 -
 drivers/net/ethernet/freescale/ucc_geth_ethtool.c   |  1 -
 12 files changed, 40 deletions(-)

diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
index 66d150872d48..13ab669ca8b3 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
@@ -110,8 +110,6 @@ static void dpaa_get_drvinfo(struct net_device *net_dev,
 
 	strlcpy(drvinfo->driver, KBUILD_MODNAME,
 		sizeof(drvinfo->driver));
-	len = snprintf(drvinfo->version, sizeof(drvinfo->version),
-		       "%X", 0);
 	len = snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
 		       "%X", 0);
 
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pf.c b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
index fc0d7d99e9a1..545a344bce00 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_pf.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
@@ -7,12 +7,6 @@
 #include <linux/of_net.h>
 #include "enetc_pf.h"
 
-#define ENETC_DRV_VER_MAJ 1
-#define ENETC_DRV_VER_MIN 0
-
-#define ENETC_DRV_VER_STR __stringify(ENETC_DRV_VER_MAJ) "." \
-			  __stringify(ENETC_DRV_VER_MIN)
-static const char enetc_drv_ver[] = ENETC_DRV_VER_STR;
 #define ENETC_DRV_NAME_STR "ENETC PF driver"
 static const char enetc_drv_name[] = ENETC_DRV_NAME_STR;
 
@@ -929,9 +923,6 @@ static int enetc_pf_probe(struct pci_dev *pdev,
 
 	netif_carrier_off(ndev);
 
-	netif_info(priv, probe, ndev, "%s v%s\n",
-		   enetc_drv_name, enetc_drv_ver);
-
 	return 0;
 
 err_reg_netdev:
@@ -959,9 +950,6 @@ static void enetc_pf_remove(struct pci_dev *pdev)
 		enetc_sriov_configure(pdev, 0);
 
 	priv = netdev_priv(si->ndev);
-	netif_info(priv, drv, si->ndev, "%s v%s remove\n",
-		   enetc_drv_name, enetc_drv_ver);
-
 	unregister_netdev(si->ndev);
 
 	enetc_mdio_remove(pf);
@@ -995,4 +983,3 @@ module_pci_driver(enetc_pf_driver);
 
 MODULE_DESCRIPTION(ENETC_DRV_NAME_STR);
 MODULE_LICENSE("Dual BSD/GPL");
-MODULE_VERSION(ENETC_DRV_VER_STR);
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_vf.c b/drivers/net/ethernet/freescale/enetc/enetc_vf.c
index ebd21bf4cfa1..28a786b2f3e7 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_vf.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_vf.c
@@ -4,12 +4,6 @@
 #include <linux/module.h>
 #include "enetc.h"
 
-#define ENETC_DRV_VER_MAJ 1
-#define ENETC_DRV_VER_MIN 0
-
-#define ENETC_DRV_VER_STR __stringify(ENETC_DRV_VER_MAJ) "." \
-			  __stringify(ENETC_DRV_VER_MIN)
-static const char enetc_drv_ver[] = ENETC_DRV_VER_STR;
 #define ENETC_DRV_NAME_STR "ENETC VF driver"
 static const char enetc_drv_name[] = ENETC_DRV_NAME_STR;
 
@@ -201,9 +195,6 @@ static int enetc_vf_probe(struct pci_dev *pdev,
 
 	netif_carrier_off(ndev);
 
-	netif_info(priv, probe, ndev, "%s v%s\n",
-		   enetc_drv_name, enetc_drv_ver);
-
 	return 0;
 
 err_reg_netdev:
@@ -225,8 +216,6 @@ static void enetc_vf_remove(struct pci_dev *pdev)
 	struct enetc_ndev_priv *priv;
 
 	priv = netdev_priv(si->ndev);
-	netif_info(priv, drv, si->ndev, "%s v%s remove\n",
-		   enetc_drv_name, enetc_drv_ver);
 	unregister_netdev(si->ndev);
 
 	enetc_free_msix(priv);
@@ -254,4 +243,3 @@ module_pci_driver(enetc_vf_driver);
 
 MODULE_DESCRIPTION(ENETC_DRV_NAME_STR);
 MODULE_LICENSE("Dual BSD/GPL");
-MODULE_VERSION(ENETC_DRV_VER_STR);
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 12edd4e358f8..af7653e341f2 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2128,7 +2128,6 @@ static void fec_enet_get_drvinfo(struct net_device *ndev,
 
 	strlcpy(info->driver, fep->pdev->dev.driver->name,
 		sizeof(info->driver));
-	strlcpy(info->version, "Revision: 1.0", sizeof(info->version));
 	strlcpy(info->bus_info, dev_name(&ndev->dev), sizeof(info->bus_info));
 }
 
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
index add61fed33ee..ce85feaac357 100644
--- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
+++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
@@ -53,7 +53,6 @@
 MODULE_AUTHOR("Pantelis Antoniou <panto@intracom.gr>");
 MODULE_DESCRIPTION("Freescale Ethernet Driver");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_MODULE_VERSION);
 
 static int fs_enet_debug = -1; /* -1 == use FS_ENET_DEF_MSG_ENABLE as value */
 module_param(fs_enet_debug, int, 0);
@@ -790,7 +789,6 @@ static void fs_get_drvinfo(struct net_device *dev,
 			    struct ethtool_drvinfo *info)
 {
 	strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver));
-	strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version));
 }
 
 static int fs_get_regs_len(struct net_device *dev)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet.h b/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
index 195fae6aec4a..5ff2634bee2f 100644
--- a/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
+++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
@@ -190,8 +190,6 @@ void fs_cleanup_bds(struct net_device *dev);
 
 #define DRV_MODULE_NAME		"fs_enet"
 #define PFX DRV_MODULE_NAME	": "
-#define DRV_MODULE_VERSION	"1.1"
-#define DRV_MODULE_RELDATE	"Sep 22, 2014"
 
 /***************************************************************************/
 
diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
index f7e5cafe89a9..b3c69e9038ea 100644
--- a/drivers/net/ethernet/freescale/gianfar.c
+++ b/drivers/net/ethernet/freescale/gianfar.c
@@ -103,8 +103,6 @@
 
 #define TX_TIMEOUT      (5*HZ)
 
-const char gfar_driver_version[] = "2.0";
-
 MODULE_AUTHOR("Freescale Semiconductor, Inc");
 MODULE_DESCRIPTION("Gianfar Ethernet Driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/freescale/gianfar.h b/drivers/net/ethernet/freescale/gianfar.h
index 432c6a818ae5..8ced783f5302 100644
--- a/drivers/net/ethernet/freescale/gianfar.h
+++ b/drivers/net/ethernet/freescale/gianfar.h
@@ -68,7 +68,6 @@ struct ethtool_rx_list {
 #define RXBUF_ALIGNMENT 64
 
 #define DRV_NAME "gfar-enet"
-extern const char gfar_driver_version[];
 
 /* MAXIMUM NUMBER OF QUEUES SUPPORTED */
 #define MAX_TX_QS	0x8
diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c
index 3c8e4e2efc07..7b69e80d6b30 100644
--- a/drivers/net/ethernet/freescale/gianfar_ethtool.c
+++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c
@@ -164,8 +164,6 @@ static void gfar_gdrvinfo(struct net_device *dev,
 			  struct ethtool_drvinfo *drvinfo)
 {
 	strlcpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver));
-	strlcpy(drvinfo->version, gfar_driver_version,
-		sizeof(drvinfo->version));
 	strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version));
 	strlcpy(drvinfo->bus_info, "N/A", sizeof(drvinfo->bus_info));
 }
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
index 0d101c00286f..6e5f6dd169b5 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -3990,5 +3990,4 @@ module_exit(ucc_geth_exit);
 
 MODULE_AUTHOR("Freescale Semiconductor, Inc");
 MODULE_DESCRIPTION(DRV_DESC);
-MODULE_VERSION(DRV_VERSION);
 MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/freescale/ucc_geth.h b/drivers/net/ethernet/freescale/ucc_geth.h
index a86a42131fc7..3fe903972195 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.h
+++ b/drivers/net/ethernet/freescale/ucc_geth.h
@@ -26,7 +26,6 @@
 
 #define DRV_DESC "QE UCC Gigabit Ethernet Controller"
 #define DRV_NAME "ucc_geth"
-#define DRV_VERSION "1.1"
 
 #define NUM_TX_QUEUES                   8
 #define NUM_RX_QUEUES                   8
diff --git a/drivers/net/ethernet/freescale/ucc_geth_ethtool.c b/drivers/net/ethernet/freescale/ucc_geth_ethtool.c
index dfebacf443fc..bc7ba70d176c 100644
--- a/drivers/net/ethernet/freescale/ucc_geth_ethtool.c
+++ b/drivers/net/ethernet/freescale/ucc_geth_ethtool.c
@@ -334,7 +334,6 @@ uec_get_drvinfo(struct net_device *netdev,
                        struct ethtool_drvinfo *drvinfo)
 {
 	strlcpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver));
-	strlcpy(drvinfo->version, DRV_VERSION, sizeof(drvinfo->version));
 	strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version));
 	strlcpy(drvinfo->bus_info, "QUICC ENGINE", sizeof(drvinfo->bus_info));
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH net-next 22/23] net/freescale: Don't set zero if FW not-available in ucc_geth
  2020-03-01 14:44 [PATCH net-next 00/23] Clean driver, module and FW versions Leon Romanovsky
  2020-03-01 14:44 ` [PATCH net-next 20/23] net/freescale: Clean drivers from static versions Leon Romanovsky
@ 2020-03-01 14:44 ` Leon Romanovsky
  2020-03-02  3:02 ` [PATCH net-next 00/23] Clean driver, module and FW versions David Miller
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Leon Romanovsky @ 2020-03-01 14:44 UTC (permalink / raw)
  To: David S . Miller, Jakub Kicinski
  Cc: Leon Romanovsky, netdev, linuxppc-dev, Li Yang

From: Leon Romanovsky <leonro@mellanox.com>

Rely on ethtool to properly present the fact that FW is not
available for the ucc_geth driver.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
 drivers/net/ethernet/freescale/ucc_geth_ethtool.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/ucc_geth_ethtool.c b/drivers/net/ethernet/freescale/ucc_geth_ethtool.c
index bc7ba70d176c..14c08a868190 100644
--- a/drivers/net/ethernet/freescale/ucc_geth_ethtool.c
+++ b/drivers/net/ethernet/freescale/ucc_geth_ethtool.c
@@ -334,7 +334,6 @@ uec_get_drvinfo(struct net_device *netdev,
                        struct ethtool_drvinfo *drvinfo)
 {
 	strlcpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver));
-	strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version));
 	strlcpy(drvinfo->bus_info, "QUICC ENGINE", sizeof(drvinfo->bus_info));
 }
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next 00/23] Clean driver, module and FW versions
  2020-03-01 14:44 [PATCH net-next 00/23] Clean driver, module and FW versions Leon Romanovsky
  2020-03-01 14:44 ` [PATCH net-next 20/23] net/freescale: Clean drivers from static versions Leon Romanovsky
  2020-03-01 14:44 ` [PATCH net-next 22/23] net/freescale: Don't set zero if FW not-available in ucc_geth Leon Romanovsky
@ 2020-03-02  3:02 ` David Miller
  2020-03-02 10:44 ` Madalin Bucur (OSS)
  2020-03-04  1:55 ` David Miller
  4 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2020-03-02  3:02 UTC (permalink / raw)
  To: leon
  Cc: ajit.khaparde, madalin.bucur, kda, prashant, _govind,
	somnath.kotur, vishal, GR-everest-linux-l2, leedom, opendmb,
	bcm-kernel-feedback-list, kuba, linus.walleij, sgoutham, pkaustub,
	aelior, ulli.kroll, sburla, fmanlunas, leonro, claudiu.manoil,
	f.fainelli, sathya.perla, michael.chan, linux-arm-kernel,
	rvatsavayi, GR-Linux-NIC-Dev, fugang.duan, sriharsha.basavapatna,
	linux-parisc, siva.kallam, rmody, netdev, linux-kernel,
	leoyang.li, hsweeten, rrichter, dchickles, linuxppc-dev, skalluru,
	benve

From: Leon Romanovsky <leon@kernel.org>
Date: Sun,  1 Mar 2020 16:44:33 +0200

> This is second batch of the series which removes various static versions
> in favour of globaly defined Linux kernel version.

This generally looks fine to me but I'll let it sit for a few days so that
others can review.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH net-next 00/23] Clean driver, module and FW versions
  2020-03-01 14:44 [PATCH net-next 00/23] Clean driver, module and FW versions Leon Romanovsky
                   ` (2 preceding siblings ...)
  2020-03-02  3:02 ` [PATCH net-next 00/23] Clean driver, module and FW versions David Miller
@ 2020-03-02 10:44 ` Madalin Bucur (OSS)
  2020-03-04  1:55 ` David Miller
  4 siblings, 0 replies; 6+ messages in thread
From: Madalin Bucur (OSS) @ 2020-03-02 10:44 UTC (permalink / raw)
  To: Leon Romanovsky, David S . Miller, Jakub Kicinski
  Cc: Ajit Khaparde, Denis Kirjanov, Prashant Sreedharan,
	Govindarajulu Varadarajan, Somnath Kotur, Vishal Kulkarni,
	GR-everest-linux-l2@marvell.com, Casey Leedom, Doug Berger,
	bcm-kernel-feedback-list@broadcom.com, Linus Walleij,
	Sunil Goutham, Parvi Kaustubhi, Ariel Elior, Hans Ulli Kroll,
	Satanand Burla, Felix Manlunas, Leon Romanovsky, Claudiu Manoil,
	Florian Fainelli, Sathya Perla, Michael Chan,
	linux-arm-kernel@lists.infradead.org, Raghu Vatsavayi,
	GR-Linux-NIC-Dev@marvell.com, Andy Duan, Sriharsha Basavapatna,
	linux-parisc@vger.kernel.org, Siva Reddy Kallam, Rasesh Mody,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Leo Li,
	Hartley Sweeten, Robert Richter, Derek Chickles,
	linuxppc-dev@lists.ozlabs.org, Sudarsana Kalluru,
	Christian Benvenuti

> -----Original Message-----
> From: David Miller <davem@davemloft.net>
> Sent: Monday, March 2, 2020 5:02 AM
> To: leon@kernel.org
> Subject: Re: [PATCH net-next 00/23] Clean driver, module and FW versions
> 
> From: Leon Romanovsky <leon@kernel.org>
> Date: Sun,  1 Mar 2020 16:44:33 +0200
> 
> > This is second batch of the series which removes various static
> > versions in favour of globaly defined Linux kernel version.
> 
> This generally looks fine to me but I'll let it sit for a few days so
> that others can review.

Reviewed drivers/net/ethernet/freescale changes, thank you!

Reviewed-by: Madalin Bucur <madalin.bucur@oss.nxp.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next 00/23] Clean driver, module and FW versions
  2020-03-01 14:44 [PATCH net-next 00/23] Clean driver, module and FW versions Leon Romanovsky
                   ` (3 preceding siblings ...)
  2020-03-02 10:44 ` Madalin Bucur (OSS)
@ 2020-03-04  1:55 ` David Miller
  4 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2020-03-04  1:55 UTC (permalink / raw)
  To: leon
  Cc: ajit.khaparde, madalin.bucur, kda, prashant, _govind,
	somnath.kotur, vishal, GR-everest-linux-l2, leedom, opendmb,
	bcm-kernel-feedback-list, kuba, linus.walleij, sgoutham, pkaustub,
	aelior, ulli.kroll, sburla, fmanlunas, leonro, claudiu.manoil,
	f.fainelli, sathya.perla, michael.chan, linux-arm-kernel,
	rvatsavayi, GR-Linux-NIC-Dev, fugang.duan, sriharsha.basavapatna,
	linux-parisc, siva.kallam, rmody, netdev, linux-kernel,
	leoyang.li, hsweeten, rrichter, dchickles, linuxppc-dev, skalluru,
	benve

From: Leon Romanovsky <leon@kernel.org>
Date: Sun,  1 Mar 2020 16:44:33 +0200

> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Hi,
> 
> This is second batch of the series which removes various static versions
> in favour of globaly defined Linux kernel version.
> 
> The first part with better cover letter can be found here
> https://lore.kernel.org/lkml/20200224085311.460338-1-leon@kernel.org
> 
> The code is based on
> 68e2c37690b0 ("Merge branch 'hsr-several-code-cleanup-for-hsr-module'")
> 
> and WIP branch is
> https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/log/?h=ethtool

Series applied, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-03-04  1:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-01 14:44 [PATCH net-next 00/23] Clean driver, module and FW versions Leon Romanovsky
2020-03-01 14:44 ` [PATCH net-next 20/23] net/freescale: Clean drivers from static versions Leon Romanovsky
2020-03-01 14:44 ` [PATCH net-next 22/23] net/freescale: Don't set zero if FW not-available in ucc_geth Leon Romanovsky
2020-03-02  3:02 ` [PATCH net-next 00/23] Clean driver, module and FW versions David Miller
2020-03-02 10:44 ` Madalin Bucur (OSS)
2020-03-04  1:55 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).