From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 814C7C3F2D1 for ; Mon, 2 Mar 2020 19:12:22 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9F3920842 for ; Mon, 2 Mar 2020 19:12:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PjUkqt13" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9F3920842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48WVBn5cRqzDqc8 for ; Tue, 3 Mar 2020 06:12:17 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=207.211.31.120; helo=us-smtp-1.mimecast.com; envelope-from=jolsa@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PjUkqt13; dkim-atps=neutral Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48WV8G2nfxzDqWw for ; Tue, 3 Mar 2020 06:10:04 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583176201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G7Hz0vVXFpbBOfFt3NDzjDOUPmMmISH4jqXPJajKvOA=; b=PjUkqt132HcBXZ3+OSFqn2nKcGGYxabCHljP4En6+X4OHu7iuU07Ae/zj0xEUPu6loyiIu 7qqxZtB/hEYcbWrPC6Ba6Ct5ywV5MerE2XMKKcfNORYcyBe8IV/+grCdrweLKhE0GDKaeM mJXe7bObJwCqxVNsL8qs7tdhamlh7Gg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-338-Q0MZdmfDNFa00WUN4iiOoA-1; Mon, 02 Mar 2020 10:08:46 -0500 X-MC-Unique: Q0MZdmfDNFa00WUN4iiOoA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B199E800D4E; Mon, 2 Mar 2020 15:08:42 +0000 (UTC) Received: from krava (ovpn-205-46.brq.redhat.com [10.40.205.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3A9C4100194E; Mon, 2 Mar 2020 15:08:22 +0000 (UTC) Date: Mon, 2 Mar 2020 16:08:19 +0100 From: Jiri Olsa To: Kajol Jain Subject: Re: [PATCH v3 6/8] perf/tools: Enhance JSON/metric infrastructure to handle "?" Message-ID: <20200302150819.GA259142@krava> References: <20200229094159.25573-1-kjain@linux.ibm.com> <20200229094159.25573-7-kjain@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200229094159.25573-7-kjain@linux.ibm.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, maddy@linux.vnet.ibm.com, peterz@infradead.org, yao.jin@linux.intel.com, mingo@kernel.org, kan.liang@linux.intel.com, ak@linux.intel.com, alexander.shishkin@linux.intel.com, anju@linux.vnet.ibm.com, mamatha4@linux.vnet.ibm.com, sukadev@linux.vnet.ibm.com, ravi.bangoria@linux.ibm.com, acme@kernel.org, jmario@redhat.com, namhyung@kernel.org, tglx@linutronix.de, mpetlan@redhat.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, jolsa@kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Feb 29, 2020 at 03:11:57PM +0530, Kajol Jain wrote: SNIP > #define PVR_VER(pvr) (((pvr) >> 16) & 0xFFFF) /* Version field */ > #define PVR_REV(pvr) (((pvr) >> 0) & 0xFFFF) /* Revison field */ > > +#define SOCKETS_INFO_FILE_PATH "/devices/hv_24x7/interface/" > + > int > get_cpuid(char *buffer, size_t sz) > { > @@ -44,3 +51,43 @@ get_cpuid_str(struct perf_pmu *pmu __maybe_unused) > > return bufp; > } > + > +int arch_get_runtimeparam(void) > +{ > + int count = 0; > + DIR *dir; > + char path[PATH_MAX]; > + const char *sysfs = sysfs__mountpoint(); > + char filename[] = "sockets"; > + FILE *file; > + char buf[16], *num; > + int data; > + > + if (!sysfs) > + goto out; > + > + snprintf(path, PATH_MAX, > + "%s" SOCKETS_INFO_FILE_PATH, sysfs); > + dir = opendir(path); > + > + if (!dir) > + goto out; > + > + strcat(path, filename); > + file = fopen(path, "r"); > + > + if (!file) > + goto out; > + > + data = fread(buf, 1, sizeof(buf), file); > + > + if (data == 0) > + goto out; > + > + count = strtol(buf, &num, 10); > +out: > + if (!count) > + count = 1; > + > + return count; we have sysfs__read_ull for this jirka