From: David Miller <davem@davemloft.net>
To: julietk@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
tlfalcon@linux.vnet.ibm.com
Subject: Re: [PATCH net] ibmvnic: Do not process device remove during device reset
Date: Mon, 09 Mar 2020 18:04:30 -0700 (PDT) [thread overview]
Message-ID: <20200309.180430.1182071186379257002.davem@davemloft.net> (raw)
In-Reply-To: <20200310000204.58596-1-julietk@linux.vnet.ibm.com>
From: Juliet Kim <julietk@linux.vnet.ibm.com>
Date: Mon, 9 Mar 2020 19:02:04 -0500
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index c75239d8820f..7ef1ae0d49bc 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -2144,6 +2144,8 @@ static void __ibmvnic_reset(struct work_struct *work)
> struct ibmvnic_adapter *adapter;
> u32 reset_state;
> int rc = 0;
> + unsigned long flags;
> + bool saved_state = false;
Please preserve the reverse christmas tree ordering of local variables.
Thank you.
prev parent reply other threads:[~2020-03-10 1:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 0:02 [PATCH net] ibmvnic: Do not process device remove during device reset Juliet Kim
2020-03-10 1:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309.180430.1182071186379257002.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=julietk@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).