From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FAKE_REPLY_C,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54CAFC10DCE for ; Thu, 12 Mar 2020 14:45:03 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 044A72071C for ; Thu, 12 Mar 2020 14:45:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1XtiEyLN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 044A72071C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48dWnl4GxhzDqvg for ; Fri, 13 Mar 2020 01:44:59 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=helgaas@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=default header.b=1XtiEyLN; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48dWkL0GFczDqHZ for ; Fri, 13 Mar 2020 01:42:01 +1100 (AEDT) Received: from localhost (mobile-166-175-186-165.mycingular.net [166.175.186.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0DFC5206E7; Thu, 12 Mar 2020 14:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584024119; bh=rwALx85sL9uxz9h24BYrbFnTq6oyh/cOVDhdniakHzk=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=1XtiEyLN/mnOQ3bewdx1k97d0rs0nBAo4iMJlADMpY54tvJoyAfqZRVkn+pY3Mear H3fiV7NixjRk6sHXRrkbfsjJ8wm/5LNnZN+pQJKFaS+gH1B2Iw/0gy43OnwJKu+JXo g4f5WXrBhK/85gaNhjO46JDvgsgtlva/prm2iMWw= Date: Thu, 12 Mar 2020 09:41:57 -0500 From: Bjorn Helgaas To: Chen Zhou Subject: Re: [PATCH -next] PCI: rpaphp: remove set but not used variable 'value' Message-ID: <20200312144157.GA110750@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200312143800.GA109542@google.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tyreld@linux.ibm.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, paulus@samba.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Mar 12, 2020 at 09:38:02AM -0500, Bjorn Helgaas wrote: > On Thu, Mar 12, 2020 at 10:04:12PM +0800, Chen Zhou wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > drivers/pci/hotplug/rpaphp_core.c: In function is_php_type: > > drivers/pci/hotplug/rpaphp_core.c:291:16: warning: > > variable value set but not used [-Wunused-but-set-variable] > > > > Reported-by: Hulk Robot > > Signed-off-by: Chen Zhou > > Michael, if you want this: > > Acked-by: Bjorn Helgaas > > If you don't mind, edit the subject to follow the convention, e.g., > > PCI: rpaphp: Remove unused variable 'value' > > Apparently simple_strtoul() is deprecated and we're supposed to use > kstrtoul() instead. Looks like kstrtoul() might simplify the code a > little, too, e.g., > > if (kstrtoul(drc_type, 0, &value) == 0) > return 1; > > return 0; I guess there are several other uses of simple_strtoul() in this file. Not sure if it's worth changing them all, just this one, or just the patch below as-is. > > --- > > drivers/pci/hotplug/rpaphp_core.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/pci/hotplug/rpaphp_core.c b/drivers/pci/hotplug/rpaphp_core.c > > index e408e40..5d871ef 100644 > > --- a/drivers/pci/hotplug/rpaphp_core.c > > +++ b/drivers/pci/hotplug/rpaphp_core.c > > @@ -288,11 +288,10 @@ EXPORT_SYMBOL_GPL(rpaphp_check_drc_props); > > > > static int is_php_type(char *drc_type) > > { > > - unsigned long value; > > char *endptr; > > > > /* PCI Hotplug nodes have an integer for drc_type */ > > - value = simple_strtoul(drc_type, &endptr, 10); > > + simple_strtoul(drc_type, &endptr, 10); > > if (endptr == drc_type) > > return 0; > > > > -- > > 2.7.4 > >