From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 802BBC0044D for ; Sat, 14 Mar 2020 11:04:45 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A4762076D for ; Sat, 14 Mar 2020 11:04:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A4762076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48ffpf6qS4zDqV8 for ; Sat, 14 Mar 2020 22:04:42 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.208.66; helo=mail-ed1-f66.google.com; envelope-from=k.kozlowski.k@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48ffmr46DBzDqRL for ; Sat, 14 Mar 2020 22:03:06 +1100 (AEDT) Received: by mail-ed1-f66.google.com with SMTP id g19so15236916eds.11 for ; Sat, 14 Mar 2020 04:03:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HXvNDpxcelYwn8PoDas8bnx/K7bC0ycG2928PB68YGs=; b=LwBsDvQ5cuuk06iLaRkPQn85u2DNdPMiD3Yc0KdWYijQNIab+ZlRGV5a2HHhbiQMe+ ny7EshUI0JzhC9+TKAv1w5JS8p05TL0tPP83aL8ntsQNWeEItC74ikakm3e+dtl42xIy J4sMowyfXxJ9GQDUyUxI6nmPuM/sKEE0ktcTtIZ+g7nfV5iDGCmsm46D6NaHmc5S+zC8 Ku3SZh2UiGZ1GNw96yyY3pMacq16RjWO47bAhFbIWUvhYwEOQdtFuysIuk5jgjQrHaer yzPXgDPk55ga5f+9H54xJiDovl1cB3JlqRUh1voQBxf4MdE3Qqhk0G0Jm5rAT17sTAER 3/mA== X-Gm-Message-State: ANhLgQ1Ps5UTIdqJK2Ck62CqH5aP7rdgm1k9M/Uv0rgjg0xglJNdj60B 2wheGlMT4RPs0pJ6+53N3qE= X-Google-Smtp-Source: ADFU+vv8nT7z/vEu1bvfu6+AMeellIORI/K4LaHKfZcEsgQyhBKLzYnFTNlP0g88C9JmPdb6eGvarg== X-Received: by 2002:a17:907:429c:: with SMTP id ny20mr14725961ejb.278.1584183783358; Sat, 14 Mar 2020 04:03:03 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id 94sm2657013eda.7.2020.03.14.04.03.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 14 Mar 2020 04:03:02 -0700 (PDT) Date: Sat, 14 Mar 2020 12:02:58 +0100 From: Krzysztof Kozlowski To: Arnd Bergmann Subject: Re: [RESEND PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation) Message-ID: <20200314110258.GA16135@kozik-lap> References: <20200219175007.13627-1-krzk@kernel.org> <20200219175007.13627-2-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200219175007.13627-2-krzk@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Jiri Slaby , Geert Uytterhoeven , "Michael S. Tsirkin" , David Airlie , Jason Wang , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , netdev@vger.kernel.org, Paul Mackerras , linux-arch@vger.kernel.org, Dave Jiang , Yoshinori Sato , Helge Deller , linux-sh@vger.kernel.org, Alexey Brodkin , Ben Skeggs , nouveau@lists.freedesktop.org, Dave Airlie , Matt Turner , linux-snps-arc@lists.infradead.org, Nick Kossifidis , Allen Hubbe , linux-alpha@vger.kernel.org, Ivan Kokshaysky , Thomas Gleixner , Mauro Carvalho Chehab , Kalle Valo , Richard Henderson , linux-parisc@vger.kernel.org, Vineet Gupta , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Daniel Vetter , Jon Mason , linux-ntb@googlegroups.com, Andrew Morton , linux-media@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Feb 19, 2020 at 06:49:59PM +0100, Krzysztof Kozlowski wrote: > The ioreadX() and ioreadX_rep() helpers have inconsistent interface. On > some architectures void *__iomem address argument is a pointer to const, > on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Suggested-by: Geert Uytterhoeven > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Arnd Bergmann Hi Arnd, This patch touches multipel file systems so no one is brave enough to pick it up. However you are mentioned as maintainer of generic asm headers so maybe you could apply it to arm-soc? Best regards, Krzysztof > > --- > > Changes since v1: > 1. Constify also ioreadX_rep() and mmio_insX(), > 2. Squash lib+alpha+powerpc+parisc+sh into one patch for bisectability, > 3. Add Geert's review. > 4. Add Arnd's review. > --- > arch/alpha/include/asm/core_apecs.h | 6 +-- > arch/alpha/include/asm/core_cia.h | 6 +-- > arch/alpha/include/asm/core_lca.h | 6 +-- > arch/alpha/include/asm/core_marvel.h | 4 +- > arch/alpha/include/asm/core_mcpcia.h | 6 +-- > arch/alpha/include/asm/core_t2.h | 2 +- > arch/alpha/include/asm/io.h | 12 ++--- > arch/alpha/include/asm/io_trivial.h | 16 +++--- > arch/alpha/include/asm/jensen.h | 2 +- > arch/alpha/include/asm/machvec.h | 6 +-- > arch/alpha/kernel/core_marvel.c | 2 +- > arch/alpha/kernel/io.c | 12 ++--- > arch/parisc/include/asm/io.h | 4 +- > arch/parisc/lib/iomap.c | 72 +++++++++++++-------------- > arch/powerpc/kernel/iomap.c | 28 +++++------ > arch/sh/kernel/iomap.c | 22 ++++---- > include/asm-generic/iomap.h | 28 +++++------ > include/linux/io-64-nonatomic-hi-lo.h | 4 +- > include/linux/io-64-nonatomic-lo-hi.h | 4 +- > lib/iomap.c | 30 +++++------ > 20 files changed, 136 insertions(+), 136 deletions(-) >