From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA203C5ACD7 for ; Tue, 17 Mar 2020 22:07:03 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BA3320714 for ; Tue, 17 Mar 2020 22:07:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s+26uggo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BA3320714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48hnMT3RRlzDqtW for ; Wed, 18 Mar 2020 09:07:01 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=richard.weiyang@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=s+26uggo; dkim-atps=neutral Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48hnKB1MWkzDqq5 for ; Wed, 18 Mar 2020 09:05:02 +1100 (AEDT) Received: by mail-wr1-x442.google.com with SMTP id b2so21538731wrj.10 for ; Tue, 17 Mar 2020 15:05:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Qiz8SPGjq8UjHt5B7MxSwjAG4ELELv3CtLSiX/rkTdo=; b=s+26uggoLggNmytLFNkdi5ReaP1mQqXWgjWy8h5Gs+gJsYAbnX71plLhfx3iTGckQJ 3mf1zQUAz7jDZ3g6nApgpqoGosK8gPPrhlFBHDcDoL9v2pE/eeoF4r27DSIx7JfTM6dW cT7v5UZFhkEwJMZWl3oh3WfUmJyG6O6uDQsG2jFaNB45EGA5y6eZYi6qOyotGpQ/P2rs MDaqKFpT2V/jik4ZT0LcexOjipeNHS2V86cxJJVDbdppigFG8Fbga86Mi/2PSd/wU7W3 35TKgLQF83iGAQp3rLZ1losEJcw8tKxBUQho2gmDuh0jeWLS80cLVtMh4PCzeXxBTvrZ v66Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=Qiz8SPGjq8UjHt5B7MxSwjAG4ELELv3CtLSiX/rkTdo=; b=IyOzQwjTP7IphfOlaInunKk2SJdHBhfGWM9Lv8nBVIgZ9uh1wPUY3oGk80rtFjS5s5 Y2DpgTasXDMBAfmHUr18xq5AWOfZ34c/igGq1DIRKaNjWOiZwfuHKZOgF+6uQXJ516e+ g58+DSG82Z/2J1/2utk5MAd7ggDCN7fgCGhjrmdHkaGZzOOGYqgFzKAYKCBLMPhcA1zH Ls9zhNYTIKBbNYPjLHJx4BcLEfUY5c3VYVRo4hoQTgABanqxxNsO+Xm+eibwAF3nG7c1 QezcmRcpl+gVg6jt6Yi34hA6t43TFkw1MWj21n2ah8gY+drZyN4SQ5BrZmPUR2kS9MfY 1Jkw== X-Gm-Message-State: ANhLgQ3GRKE1UZUTqDStT9MX7LWf6gS0f0Y6y7bGGd2rFFUAVS//qgSG +jCfmMirnJsUZ0jAQjVHtC4= X-Google-Smtp-Source: ADFU+vvUbJs7CjVtSah/hWS9CT/exY7FEYlJgzu0BJZSQqsLIr7AAJOzF8YKAtYskOQ1IKl756J0tA== X-Received: by 2002:adf:ef12:: with SMTP id e18mr1155345wro.108.1584482697768; Tue, 17 Mar 2020 15:04:57 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id y200sm1059104wmc.20.2020.03.17.15.04.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Mar 2020 15:04:57 -0700 (PDT) Date: Tue, 17 Mar 2020 22:04:56 +0000 From: Wei Yang To: David Hildenbrand Subject: Re: [PATCH v2 4/8] powernv/memtrace: always online added memory blocks Message-ID: <20200317220456.wczzkgtqwgxjw5c6@master> References: <20200317104942.11178-1-david@redhat.com> <20200317104942.11178-5-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200317104942.11178-5-david@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Cc: linux-hyperv@vger.kernel.org, Baoquan He , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Michal Hocko , linux-mm@kvack.org, Paul Mackerras , Andrew Morton , Wei Yang , linuxppc-dev@lists.ozlabs.org, Oscar Salvador Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Mar 17, 2020 at 11:49:38AM +0100, David Hildenbrand wrote: >Let's always try to online the re-added memory blocks. In case add_memory() >already onlined the added memory blocks, the first device_online() call >will fail and stop processing the remaining memory blocks. > >This avoids manually having to check memhp_auto_online. > >Note: PPC always onlines all hotplugged memory directly from the kernel >as well - something that is handled by user space on other >architectures. > >Cc: Benjamin Herrenschmidt >Cc: Paul Mackerras >Cc: Michael Ellerman >Cc: Andrew Morton >Cc: Greg Kroah-Hartman >Cc: Michal Hocko >Cc: Oscar Salvador >Cc: "Rafael J. Wysocki" >Cc: Baoquan He >Cc: Wei Yang >Cc: linuxppc-dev@lists.ozlabs.org >Signed-off-by: David Hildenbrand Looks good. Reviewed-by: Wei Yang >--- > arch/powerpc/platforms/powernv/memtrace.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > >diff --git a/arch/powerpc/platforms/powernv/memtrace.c b/arch/powerpc/platforms/powernv/memtrace.c >index d6d64f8718e6..13b369d2cc45 100644 >--- a/arch/powerpc/platforms/powernv/memtrace.c >+++ b/arch/powerpc/platforms/powernv/memtrace.c >@@ -231,16 +231,10 @@ static int memtrace_online(void) > continue; > } > >- /* >- * If kernel isn't compiled with the auto online option >- * we need to online the memory ourselves. >- */ >- if (!memhp_auto_online) { >- lock_device_hotplug(); >- walk_memory_blocks(ent->start, ent->size, NULL, >- online_mem_block); >- unlock_device_hotplug(); >- } >+ lock_device_hotplug(); >+ walk_memory_blocks(ent->start, ent->size, NULL, >+ online_mem_block); >+ unlock_device_hotplug(); > > /* > * Memory was added successfully so clean up references to it >-- >2.24.1 -- Wei Yang Help you, Help me