From: kbuild test robot <lkp@intel.com>
To: Anton Blanchard <anton@ozlabs.org>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Nicholas Piggin <npiggin@gmail.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/vdso: Fix multiple issues with sys_call_table
Date: Thu, 19 Mar 2020 01:06:52 +0800 [thread overview]
Message-ID: <202003190131.v6itq26Q%lkp@intel.com> (raw)
In-Reply-To: <20200306135705.7f80fcad@kryten.localdomain>
[-- Attachment #1: Type: text/plain, Size: 4105 bytes --]
Hi Anton,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on powerpc/next]
[also build test WARNING on linux/master linus/master v5.6-rc6 next-20200317]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Anton-Blanchard/powerpc-vdso-Fix-multiple-issues-with-sys_call_table/20200306-134043
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-randconfig-a001-20200318 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
arch/powerpc/kernel/vdso.c: In function 'vdso_setup_syscall_map':
>> arch/powerpc/kernel/vdso.c:662:25: warning: comparison between pointer and integer
662 | if (sys_call_table[i] != sys_ni_syscall)
| ^~
vim +662 arch/powerpc/kernel/vdso.c
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 641
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 642 /*
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 643 * Called from setup_arch to initialize the bitmap of available
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 644 * syscalls in the systemcfg page
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 645 */
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 646 static void __init vdso_setup_syscall_map(void)
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 647 {
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 648 unsigned int i;
457c1792bcc570 Anton Blanchard 2020-03-06 649 unsigned long ni_syscall;
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 650
457c1792bcc570 Anton Blanchard 2020-03-06 651 ni_syscall = (unsigned long)dereference_kernel_function_descriptor(sys_ni_syscall);
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 652
f43194e45852b0 Rashmica Gupta 2015-11-19 653 for (i = 0; i < NR_syscalls; i++) {
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 654 #ifdef CONFIG_PPC64
457c1792bcc570 Anton Blanchard 2020-03-06 655 if (sys_call_table[i] != ni_syscall)
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 656 vdso_data->syscall_map_64[i >> 5] |=
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 657 0x80000000UL >> (i & 0x1f);
457c1792bcc570 Anton Blanchard 2020-03-06 658 if (compat_sys_call_table[i] != ni_syscall)
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 659 vdso_data->syscall_map_32[i >> 5] |=
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 660 0x80000000UL >> (i & 0x1f);
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 661 #else /* CONFIG_PPC64 */
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 @662 if (sys_call_table[i] != sys_ni_syscall)
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 663 vdso_data->syscall_map_32[i >> 5] |=
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 664 0x80000000UL >> (i & 0x1f);
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 665 #endif /* CONFIG_PPC64 */
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 666 }
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 667 }
a7f290dad32ee3 Benjamin Herrenschmidt 2005-11-11 668
:::::: The code at line 662 was first introduced by commit
:::::: a7f290dad32ee34d931561b7943c858fe2aae503 [PATCH] powerpc: Merge vdso's and add vdso support to 32 bits kernel
:::::: TO: Benjamin Herrenschmidt <benh@kernel.crashing.org>
:::::: CC: Paul Mackerras <paulus@samba.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28069 bytes --]
next prev parent reply other threads:[~2020-03-18 17:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 2:57 [PATCH] powerpc/vdso: Fix multiple issues with sys_call_table Anton Blanchard
2020-03-18 17:06 ` kbuild test robot [this message]
2020-03-19 1:10 ` Michael Ellerman
2021-06-10 11:36 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202003190131.v6itq26Q%lkp@intel.com \
--to=lkp@intel.com \
--cc=anton@ozlabs.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).