From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Sachin Sant <sachinp@linux.vnet.ibm.com>,
Nathan Lynch <nathanl@linux.ibm.com>,
Mel Gorman <mgorman@techsingularity.net>,
Michal Hocko <mhocko@kernel.org>,
Pekka Enberg <penberg@kernel.org>,
linux-mm@kvack.org, Kirill Tkhai <ktkhai@virtuozzo.com>,
David Rientjes <rientjes@google.com>,
Christopher Lameter <cl@linux.com>,
bharata@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [RFC 1/2] mm, slub: prevent kmalloc_node crashes and memory leaks
Date: Thu, 19 Mar 2020 19:35:49 +0530 [thread overview]
Message-ID: <20200319140549.GF4879@linux.vnet.ibm.com> (raw)
In-Reply-To: <339cf655-393e-c48e-4797-86f61df56c35@suse.cz>
* Vlastimil Babka <vbabka@suse.cz> [2020-03-19 14:47:58]:
> ----8<----
> diff --git a/mm/slub.c b/mm/slub.c
> index 17dc00e33115..7113b1f9cd77 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1973,8 +1973,6 @@ static void *get_partial(struct kmem_cache *s, gfp_t flags, int node,
>
> if (node == NUMA_NO_NODE)
> searchnode = numa_mem_id();
> - else if (!node_present_pages(node))
> - searchnode = node_to_mem_node(node);
>
> object = get_partial_node(s, get_node(s, searchnode), c, flags);
Are we okay with passing a node to get_partial_node with !NUMA_NO_NODE and
!N_MEMORY including possible nodes?
> if (object || node != NUMA_NO_NODE)
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2020-03-19 14:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 14:42 [RFC 1/2] mm, slub: prevent kmalloc_node crashes and memory leaks Vlastimil Babka
2020-03-18 16:06 ` Bharata B Rao
2020-03-18 16:10 ` Vlastimil Babka
2020-03-18 16:51 ` Vlastimil Babka
2020-03-19 8:52 ` Sachin Sant
2020-03-19 13:23 ` Vlastimil Babka
2020-03-19 13:26 ` Sachin Sant
2020-03-19 13:47 ` Vlastimil Babka
2020-03-19 14:05 ` Srikar Dronamraju [this message]
2020-03-19 14:10 ` Vlastimil Babka
2020-03-20 7:46 ` Srikar Dronamraju
2020-03-20 8:43 ` Vlastimil Babka
2020-03-20 10:10 ` Srikar Dronamraju
2020-03-19 14:59 ` Sachin Sant
2020-03-20 3:42 ` Bharata B Rao
2020-03-20 8:37 ` Vlastimil Babka
2020-03-20 8:44 ` Bharata B Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319140549.GF4879@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=bharata@linux.ibm.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=nathanl@linux.ibm.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=sachinp@linux.vnet.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).