From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] arch/powerpc/64: Avoid isync in flush_dcache_range
Date: Fri, 20 Mar 2020 10:27:40 -0500 [thread overview]
Message-ID: <20200320152740.GG22482@gate.crashing.org> (raw)
In-Reply-To: <c98c0044-39ec-452d-34db-f7284e4497df@linux.ibm.com>
On Fri, Mar 20, 2020 at 08:38:42PM +0530, Aneesh Kumar K.V wrote:
> On 3/20/20 8:35 PM, Segher Boessenkool wrote:
> >On Fri, Mar 20, 2020 at 04:02:42PM +0530, Aneesh Kumar K.V wrote:
> >>As per ISA and isync is only needed on instruction cache
> >>block invalidate. Remove the same from dcache invalidate.
> >
> >Is that true on older CPUs?
> >
>
> That is what I found by checking with hardware team.
Oh, the comment right before this function says "does not invalidat
the corresponding insncache blocks", so this looks fine, sorry for not
looking closely enough before.
> One thing i was not
> able to get full confirmation about was the usage of 'sync' before 'dcbf'.
Yeah, this looks like something that would matter on some implementations.
Would it make anything measurably faster if you would remove that sync?
Segher
next prev parent reply other threads:[~2020-03-20 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 10:32 [PATCH] arch/powerpc/64: Avoid isync in flush_dcache_range Aneesh Kumar K.V
2020-03-20 15:05 ` Segher Boessenkool
2020-03-20 15:08 ` Aneesh Kumar K.V
2020-03-20 15:27 ` Segher Boessenkool [this message]
2020-04-01 12:53 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320152740.GG22482@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).