* [PATCH] powerpc/44x: Make AKEBONO depends on NET
@ 2020-03-30 14:31 YueHaibing
2020-03-31 0:58 ` Michael Ellerman
2020-03-31 16:53 ` Christoph Hellwig
0 siblings, 2 replies; 4+ messages in thread
From: YueHaibing @ 2020-03-30 14:31 UTC (permalink / raw)
To: mporter, benh, paulus, mpe
Cc: alistair, YueHaibing, linuxppc-dev, linux-kernel
Fix Kconfig warnings:
WARNING: unmet direct dependencies detected for NETDEVICES
Depends on [n]: NET [=n]
Selected by [y]:
- AKEBONO [=y] && PPC_47x [=y]
WARNING: unmet direct dependencies detected for ETHERNET
Depends on [n]: NETDEVICES [=y] && NET [=n]
Selected by [y]:
- AKEBONO [=y] && PPC_47x [=y]
AKEBONO select NETDEVICES and ETHERNET unconditionally,
If NET is not set, build fails. Add this dependcy to fix this.
Fixes: 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
arch/powerpc/platforms/44x/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
index 25ebe634a661..394f662d7df2 100644
--- a/arch/powerpc/platforms/44x/Kconfig
+++ b/arch/powerpc/platforms/44x/Kconfig
@@ -199,6 +199,7 @@ config FSP2
config AKEBONO
bool "IBM Akebono (476gtr) Support"
depends on PPC_47x
+ depends on NET
select SWIOTLB
select 476FPE
select PPC4xx_PCI_EXPRESS
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc/44x: Make AKEBONO depends on NET
2020-03-30 14:31 [PATCH] powerpc/44x: Make AKEBONO depends on NET YueHaibing
@ 2020-03-31 0:58 ` Michael Ellerman
2020-03-31 3:05 ` Yuehaibing
2020-03-31 16:53 ` Christoph Hellwig
1 sibling, 1 reply; 4+ messages in thread
From: Michael Ellerman @ 2020-03-31 0:58 UTC (permalink / raw)
To: YueHaibing, mporter, benh, paulus
Cc: alistair, YueHaibing, linuxppc-dev, linux-kernel
YueHaibing <yuehaibing@huawei.com> writes:
> Fix Kconfig warnings:
>
> WARNING: unmet direct dependencies detected for NETDEVICES
> Depends on [n]: NET [=n]
> Selected by [y]:
> - AKEBONO [=y] && PPC_47x [=y]
>
> WARNING: unmet direct dependencies detected for ETHERNET
> Depends on [n]: NETDEVICES [=y] && NET [=n]
> Selected by [y]:
> - AKEBONO [=y] && PPC_47x [=y]
>
> AKEBONO select NETDEVICES and ETHERNET unconditionally,
It shouldn't do that, that's the job of a defconfig.
It might want to enable NET_VENDOR_IBM iff the config already has NET
and other dependencies enabled.
So the patch below might work?
cheers
diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
index 25ebe634a661..32aac4f40f1b 100644
--- a/arch/powerpc/platforms/44x/Kconfig
+++ b/arch/powerpc/platforms/44x/Kconfig
@@ -207,9 +207,7 @@ config AKEBONO
select PPC4xx_HSTA_MSI
select I2C
select I2C_IBM_IIC
- select NETDEVICES
- select ETHERNET
- select NET_VENDOR_IBM
+ imply NET_VENDOR_IBM
select IBM_EMAC_EMAC4 if IBM_EMAC
select USB if USB_SUPPORT
select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
> If NET is not set, build fails. Add this dependcy to fix this.
>
> Fixes: 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> arch/powerpc/platforms/44x/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
> index 25ebe634a661..394f662d7df2 100644
> --- a/arch/powerpc/platforms/44x/Kconfig
> +++ b/arch/powerpc/platforms/44x/Kconfig
> @@ -199,6 +199,7 @@ config FSP2
> config AKEBONO
> bool "IBM Akebono (476gtr) Support"
> depends on PPC_47x
> + depends on NET
> select SWIOTLB
> select 476FPE
> select PPC4xx_PCI_EXPRESS
> --
> 2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc/44x: Make AKEBONO depends on NET
2020-03-31 0:58 ` Michael Ellerman
@ 2020-03-31 3:05 ` Yuehaibing
0 siblings, 0 replies; 4+ messages in thread
From: Yuehaibing @ 2020-03-31 3:05 UTC (permalink / raw)
To: Michael Ellerman, mporter, benh, paulus
Cc: alistair, linuxppc-dev, linux-kernel
On 2020/3/31 8:58, Michael Ellerman wrote:
> YueHaibing <yuehaibing@huawei.com> writes:
>> Fix Kconfig warnings:
>>
>> WARNING: unmet direct dependencies detected for NETDEVICES
>> Depends on [n]: NET [=n]
>> Selected by [y]:
>> - AKEBONO [=y] && PPC_47x [=y]
>>
>> WARNING: unmet direct dependencies detected for ETHERNET
>> Depends on [n]: NETDEVICES [=y] && NET [=n]
>> Selected by [y]:
>> - AKEBONO [=y] && PPC_47x [=y]
>>
>> AKEBONO select NETDEVICES and ETHERNET unconditionally,
>
> It shouldn't do that, that's the job of a defconfig.
>
> It might want to enable NET_VENDOR_IBM iff the config already has NET
> and other dependencies enabled.
>
> So the patch below might work?
Yes, It works for me, Thanks!
Tested-by: YueHaibing <yuehaibing@huawei.com> # build-tested
>
> cheers
>
> diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
> index 25ebe634a661..32aac4f40f1b 100644
> --- a/arch/powerpc/platforms/44x/Kconfig
> +++ b/arch/powerpc/platforms/44x/Kconfig
> @@ -207,9 +207,7 @@ config AKEBONO
> select PPC4xx_HSTA_MSI
> select I2C
> select I2C_IBM_IIC
> - select NETDEVICES
> - select ETHERNET
> - select NET_VENDOR_IBM
> + imply NET_VENDOR_IBM
> select IBM_EMAC_EMAC4 if IBM_EMAC
> select USB if USB_SUPPORT
> select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
>
>
>
>> If NET is not set, build fails. Add this dependcy to fix this.
>>
>> Fixes: 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> arch/powerpc/platforms/44x/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
>> index 25ebe634a661..394f662d7df2 100644
>> --- a/arch/powerpc/platforms/44x/Kconfig
>> +++ b/arch/powerpc/platforms/44x/Kconfig
>> @@ -199,6 +199,7 @@ config FSP2
>> config AKEBONO
>> bool "IBM Akebono (476gtr) Support"
>> depends on PPC_47x
>> + depends on NET
>> select SWIOTLB
>> select 476FPE
>> select PPC4xx_PCI_EXPRESS
>> --
>> 2.17.1
>
> .
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/44x: Make AKEBONO depends on NET
2020-03-30 14:31 [PATCH] powerpc/44x: Make AKEBONO depends on NET YueHaibing
2020-03-31 0:58 ` Michael Ellerman
@ 2020-03-31 16:53 ` Christoph Hellwig
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2020-03-31 16:53 UTC (permalink / raw)
To: YueHaibing; +Cc: linux-kernel, paulus, alistair, linuxppc-dev
Why would a board select a network driver? That is what defconfig
files are for! I thin kthe select should just go away.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-31 17:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-30 14:31 [PATCH] powerpc/44x: Make AKEBONO depends on NET YueHaibing
2020-03-31 0:58 ` Michael Ellerman
2020-03-31 3:05 ` Yuehaibing
2020-03-31 16:53 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).