* [PATCH] tty: hvc: remove hvcs_driver_string
@ 2020-04-03 7:13 Jason Yan
2020-04-03 7:30 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-03 7:13 UTC (permalink / raw)
To: gregkh, jslaby, linuxppc-dev; +Cc: Jason Yan
No users of hvcs_driver_string, remove it. This fixes the following gcc
warning:
drivers/tty/hvc/hvcs.c:199:19: warning: ‘hvcs_driver_string’ defined but
not used [-Wunused-const-variable=]
static const char hvcs_driver_string[]
^~~~~~~~~~~~~~~~~~
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/tty/hvc/hvcs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c
index ee0604cd9c6b..55105ac38f89 100644
--- a/drivers/tty/hvc/hvcs.c
+++ b/drivers/tty/hvc/hvcs.c
@@ -196,8 +196,6 @@ module_param(hvcs_parm_num_devs, int, 0);
static const char hvcs_driver_name[] = "hvcs";
static const char hvcs_device_node[] = "hvcs";
-static const char hvcs_driver_string[]
- = "IBM hvcs (Hypervisor Virtual Console Server) Driver";
/* Status of partner info rescan triggered via sysfs. */
static int hvcs_rescan_status;
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tty: hvc: remove hvcs_driver_string
2020-04-03 7:13 [PATCH] tty: hvc: remove hvcs_driver_string Jason Yan
@ 2020-04-03 7:30 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2020-04-03 7:30 UTC (permalink / raw)
To: Jason Yan, gregkh, linuxppc-dev
On 03. 04. 20, 9:13, Jason Yan wrote:
> No users of hvcs_driver_string, remove it. This fixes the following gcc
> warning:
>
> drivers/tty/hvc/hvcs.c:199:19: warning: ‘hvcs_driver_string’ defined but
> not used [-Wunused-const-variable=]
> static const char hvcs_driver_string[]
> ^~~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Acked-by: Jiri Slaby <jslaby@suse.cz>
It fixes a commit from 2011:
commit c7704d352d45de47333f2d9f10aead820b49044c
Author: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Sun Feb 6 18:26:25 2011 +0000
powerpc/pseries: Reduce HVCS driver insanity
!
> ---
> drivers/tty/hvc/hvcs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c
> index ee0604cd9c6b..55105ac38f89 100644
> --- a/drivers/tty/hvc/hvcs.c
> +++ b/drivers/tty/hvc/hvcs.c
> @@ -196,8 +196,6 @@ module_param(hvcs_parm_num_devs, int, 0);
>
> static const char hvcs_driver_name[] = "hvcs";
> static const char hvcs_device_node[] = "hvcs";
> -static const char hvcs_driver_string[]
> - = "IBM hvcs (Hypervisor Virtual Console Server) Driver";
>
> /* Status of partner info rescan triggered via sysfs. */
> static int hvcs_rescan_status;
>
--
js
suse labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-03 7:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-03 7:13 [PATCH] tty: hvc: remove hvcs_driver_string Jason Yan
2020-04-03 7:30 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).