From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54CFAC2BA19 for ; Mon, 6 Apr 2020 09:41:52 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C15D72051A for ; Mon, 6 Apr 2020 09:41:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lUin6sw0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C15D72051A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48wltP6XYYzDqp7 for ; Mon, 6 Apr 2020 19:41:49 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::541; helo=mail-pg1-x541.google.com; envelope-from=hqjagain@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=lUin6sw0; dkim-atps=neutral Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48wlr92V9tzDqnx for ; Mon, 6 Apr 2020 19:39:53 +1000 (AEST) Received: by mail-pg1-x541.google.com with SMTP id c23so7291472pgj.3 for ; Mon, 06 Apr 2020 02:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=UphhKKOKLoodwVftKKdXY3z6VPYBVP/K0NIVc4HqEz0=; b=lUin6sw0XNT0KJ8AK2i8H7TlaDQXkoCsJVR85w7MC2UsYwyQ69rTBN/0H5cFJq3tsY EI3njv470YcI66Z+laB3Hzun01P/u51mCCOzA5MdYpCSqrrFU/sp33el04XikkYxtYmp wnQldO6+6yd0jvMk44MDR/VF1Ta+TCgjmu91F+FjjWhJs8vY2Jr7sXEDvGrLOA974lLo nwOpHqxoJh4kqnPZH80LPFSebZIxoWwLO5uAeFUilT5t+3s0anVt2mliNeDT7mNfEQ0u AgCCmqrrMCVs04l8m23JwIfyhbVfC0Lhzxyomkg6qeK7tURpN0Abie+EwlVXLeJuenEV fNEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=UphhKKOKLoodwVftKKdXY3z6VPYBVP/K0NIVc4HqEz0=; b=oFe1NrVe4pw4wIn1JmGmia5Po0Ks4yFq02+8aFlUsJdbUN4gzjbVI5Y2Omdia21U8O XLRIHqXAKb83k0adxU3YBDCUMUAq00x0sIghLyaRUh2fjqIaXj5TL4bBjvF3/C8Zcec7 bpgNJlz+wDw9KMjYp5oYqnVtuX4Z8+54pklaCDHqleuB1qy7DtmBJ50vQPNIDv36KRFe ilymrtT3Rc2ifmkf3Omx6HAwdbtZu32JI/haqkMe6/ZLuPkJZ/8AxzPl+C3rHrrlcz4r zKD9f5MD1p4acnAPliFcVP7ifCTdCwDuwnJ8oUQSUD1+HwjRQwDOu6SSQQaLqUaAtUQ3 thyQ== X-Gm-Message-State: AGi0PuZRUkB3/Osa/I3PZlde4sJ4wCfq4+6u7cdH6JvObRDWz1SnzKXH sLhPkEbAyhGWjm40uMZwicc= X-Google-Smtp-Source: APiQypLJ5Y3misFwUfgYpGklC18wiNMPhOZ1LWHezVl5ddP3cePBI+Oo7rsxkPHJGRmbCdra+q0o+Q== X-Received: by 2002:a63:2057:: with SMTP id r23mr20805535pgm.232.1586165990812; Mon, 06 Apr 2020 02:39:50 -0700 (PDT) Received: from localhost (n112120135125.netvigator.com. [112.120.135.125]) by smtp.gmail.com with ESMTPSA id e7sm11248239pfm.3.2020.04.06.02.39.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Apr 2020 02:39:50 -0700 (PDT) From: Qiujun Huang To: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, oohall@gmail.com Subject: [PATCH v4] powerpc/powernv: add NULL check after kzalloc in opal_add_one_export Date: Mon, 6 Apr 2020 17:39:44 +0800 Message-Id: <20200406093944.4174-1-hqjagain@gmail.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Markus.Elfring@web.de, tglx@linutronix.de, linuxppc-dev@lists.ozlabs.org, Qiujun Huang Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Here needs a NULL check as kzalloc may fail returning NULL. Issue was found by coccinelle. Generated by: scripts/coccinelle/null/kmerr.cocci Signed-off-by: Qiujun Huang Reviewed-by: Oliver O'Halloran --- v3->v4: Added the information about coccinelle script. Added change log. Added Oliver's Reviewed-by. v2->v3: Removed redundant assignment to 'attr' and 'name'. v1->v2: Just return -ENOMEM if attr is NULL. --- arch/powerpc/platforms/powernv/opal.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c index 2b3dfd0b6cdd..908d749bcef5 100644 --- a/arch/powerpc/platforms/powernv/opal.c +++ b/arch/powerpc/platforms/powernv/opal.c @@ -801,16 +801,19 @@ static ssize_t export_attr_read(struct file *fp, struct kobject *kobj, static int opal_add_one_export(struct kobject *parent, const char *export_name, struct device_node *np, const char *prop_name) { - struct bin_attribute *attr = NULL; - const char *name = NULL; + struct bin_attribute *attr; + const char *name; u64 vals[2]; int rc; rc = of_property_read_u64_array(np, prop_name, &vals[0], 2); if (rc) - goto out; + return rc; attr = kzalloc(sizeof(*attr), GFP_KERNEL); + if (!attr) + return -ENOMEM; + name = kstrdup(export_name, GFP_KERNEL); if (!name) { rc = -ENOMEM; -- 2.17.1